DoD is used continuously especially before a release goes out. DoD occurs continuously with activities such as design, implementation, testing, documenting, merging (topic branches), getting feedback, iterating, etc. Other activities (Code Formatting, Polishing, Ticket Closing, etc) are "tie-up" tasks and necessarily happen at the end, right before a release.
As for the "contribution process", there is not much difference. A JIRA ticket is filed for the PR (especially for not committers) and the ticket progresses as any other ticket would. Finally, most Spring projects doe not have the luxury of having a "reviewer", mostly because there are 1 to many projects per engineer. Some projects like the core Spring Framework, Spring Boot, Spring XD, Spring Cloud, etc, have a lot more eyes on it and so they do involve a more formal review process. On the Spring Data team, for instance, Oliver is trying to have everyone work on minimally 2 SD modules. That way, each engineer has someone who is familiar with the project and can share ideas with the other (a sanity check). But, for the most part, review, like refactoring, is something that needs to be continuous. Besides, the code is never done, really, ;-) -j On Mon, Nov 2, 2015 at 2:23 PM, Anthony Baker <[email protected]> wrote: > Practically speaking, when is the DOD used? Also, how does this differ > from the contribution process? > > I don’t see a review (CTR) step. > > Anthony > > > > On Nov 2, 2015, at 1:33 PM, William Markito <[email protected]> wrote: > > > > +1 > > > > Just one question, what is snapshot build deployed ? Is it the same as > > snapshot build successfully completed ? > > > > On Mon, Nov 2, 2015 at 12:44 PM, John Blum <[email protected]> wrote: > > > >> +1 > >> > >> On Mon, Nov 2, 2015 at 12:36 PM, Udo Kohlmeyer <[email protected]> > >> wrote: > >> > >>> +1 > >>> On 3 Nov 2015 7:14 am, "Kirk Lund" <[email protected]> wrote: > >>> > >>>> I think we need to settle on a formal Definition of Done (DOD) for > >> Apache > >>>> Geode. Again, borrowing from Spring Data we could start with what they > >>>> define and add to it: > >>>> > >>>> > >>>> - Implemented according to specification in the ticket > >>>> - Unit tested > >>>> - Integration tested > >>>> - Reference documentation updated > >>>> - Changelog updated > >>>> - Code formatted appropriately > >>>> - JavaDoc polished > >>>> - Feature branch merged into master [develop?] > >>>> - Snapshot build deployed > >>>> - Ticket closed > >>>> > >>>> > >>>> https://github.com/spring-projects/spring-data-commons/wiki/DOD > >>>> > >>>> Any thoughts or feedback? > >>>> > >>>> -Kirk > >>>> > >>> > >> > >> > >> > >> -- > >> -John > >> 503-504-8657 > >> john.blum10101 (skype) > >> > > > > > > > > -- > > > > William Markito Oliveira > > -- For questions about Apache Geode, please write to > > *[email protected] > > <[email protected]>* > > -- -John 503-504-8657 john.blum10101 (skype)
