> On Nov. 4, 2015, 10:10 p.m., Dan Smith wrote: > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/OplogJUnitTest.java, > > line 3851 > > <https://reviews.apache.org/r/39956/diff/1/?file=1115979#file1115979line3851> > > > > Should this be a set, not a list?
Agree. A set will be the ideal structure in this case. Thanks ! - Ashvin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39956/#review105153 ----------------------------------------------------------- On Nov. 4, 2015, 9:58 p.m., Ashvin A wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39956/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2015, 9:58 p.m.) > > > Review request for geode and Dan Smith. > > > Repository: geode > > > Description > ------- > > KRF files are created asynchronously. The test needs to wait for the files to > be > created before checking header content. > > I have used couple of Java 8 features in the test. > > > Diffs > ----- > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/Oplog.java > f0b33f1622f9c2cb094458759bdebe5756b2df29 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/OplogJUnitTest.java > 1fc39bfb873d1b5e91a01316ba12b1a6b786dbda > > Diff: https://reviews.apache.org/r/39956/diff/ > > > Testing > ------- > > > Thanks, > > Ashvin A > >
