Github user upthewaterspout commented on the pull request:
https://github.com/apache/incubator-geode/pull/29#issuecomment-154219832
Looks good! I noticed you left in the localProperties and globalProperties
fields on PartitionAttributesImpl, as well as leaving the toData/fromData
methods alone in that class. Was that to avoid breaking serialization
compatibility?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
