----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40096/#review105742 -----------------------------------------------------------
Ship it! Looks good! I don't know if the internal interfaces need to be marked as experimental, but it probably doesn't hurt if we think they might become public interfaces at some point. - Dan Smith On Nov. 9, 2015, 6:53 p.m., Ashvin A wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40096/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2015, 6:53 p.m.) > > > Review request for geode, Dan Smith and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > GEODE-11: Mark Lucene API as experimental > > > Diffs > ----- > > gemfire-lucene/build.gradle 3303a6931b8e52e8155dd76b9385ea78144d63c5 > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/LuceneIndex.java > fc9752ae5d411aadbf6da93afc7dfae03ff0006f > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/LuceneQuery.java > 09d3a0786804b73bd71b2c69c9a83fb81bffe280 > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/LuceneQueryFactory.java > eea4b8863dd9d82deb6f249e127179b978a6574e > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/LuceneQueryProvider.java > cad90958c8ac7de6eff04e63107ff335c5759695 > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/LuceneQueryResults.java > 62aada2fc87b70ddb04b1fa7192f4c8fdcf28a3c > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/LuceneResultStruct.java > 6ed0b99dcb1ba050a00086572a9bce7b6eafabad > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/LuceneService.java > 6c629de3696f2951425eefb44f2e4901fb3b9d36 > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/LuceneServiceProvider.java > 35427ae02537ae1589c1cfe4f33e807eb18b8786 > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/distributed/CollectorManager.java > 41c3f5f3a959ef4916473f0f812ee397e22a9887 > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexResultCollector.java > 94931a4c879d1643bcdec6826173e155016a32f9 > > Diff: https://reviews.apache.org/r/40096/diff/ > > > Testing > ------- > > > Thanks, > > Ashvin A > >
