> On Nov. 11, 2015, 11:36 p.m., Jianxia Chen wrote: > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java, > > line 427 > > <https://reviews.apache.org/r/40085/diff/2/?file=1120007#file1120007line427> > > > > The pingResp should be renamed somehow. We are using heart beat as the > > name.
You're right, though this was an existing variable, not something I added > On Nov. 11, 2015, 11:36 p.m., Jianxia Chen wrote: > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java, > > line 484 > > <https://reviews.apache.org/r/40085/diff/2/?file=1120007#file1120007line484> > > > > These comments can be removed. okay - Bruce ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40085/#review106168 ----------------------------------------------------------- On Nov. 9, 2015, 4:41 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40085/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2015, 4:41 p.m.) > > > Review request for geode, anilkumar gingade, Hitesh Khamesra, Jason Huynh, > Jianxia Chen, and Lynn Gallinat. > > > Repository: geode > > > Description > ------- > > In integration testing members were, under heavy load, being forced out > of the distributed system in spite of the new tcp/ip final-checks. > > This change set adds a recent-activity check to the doTCPCheckMember method > of GMSHealthMonitor. It also corrects this method to use SocketCreator with > a background timeout task in case the tcp/ip socket timeout fails to work (as > it sometimes does). > > During testing I also saw that GMSJoinLeave was not initiating a > forced-disconnect if it received a membership view showing that it was no > longer in the distributed system and modified it to do so. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java > 0307f5badb27148a772c32c506688c6647965bc8 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 4b1993f5be3de4b55d344a1285108ea716fbbfb9 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java > 89282c05a09792083b0f3cab7a7da882641d7012 > > Diff: https://reviews.apache.org/r/40085/diff/ > > > Testing > ------- > > unit tests, integration testing > > > Thanks, > > Bruce Schuchardt > >
