> On Nov. 13, 2015, 7:19 p.m., Barry Oglesby wrote: > > Do we need to reset the other stats too, or are these two good enough?
I don't think we should reset the other stats. The rest of the stats are counters, like eventsReceived. The GatewaySender was not destroyed, it was just stopped and restarted. So I think it makes sense for those counters to keep counting up. The queue size was definitely incorrect because the queue is empty after stopping and restarting the gateway, but the stats were not reflecting that. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40272/#review106489 ----------------------------------------------------------- On Nov. 13, 2015, 1:45 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40272/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2015, 1:45 a.m.) > > > Review request for geode, Ashvin A and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > GEODE-546: Resetting stats when AbstractGatewaySender is stopped > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java > bc1161888c795ac1a874899a63ba930c8fda48e6 > > gemfire-core/src/test/java/com/gemstone/gemfire/cache/asyncqueue/internal/SerialAsyncEventQueueImplJUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/40272/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
