> On Nov. 16, 2015, 10:38 p.m., Dan Smith wrote: > > Does this mean that this AlertLevelChangeMessage message is not acked? Does > > that have any implications for your test, since the alert level may not be > > changed everywhere for some period of time after it is set?
I don't believe it is acked. The test contains explicit gates which wait for propagation. - Jens ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40369/#review106754 ----------------------------------------------------------- On Nov. 16, 2015, 9:48 p.m., Jens Deppe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40369/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 9:48 p.m.) > > > Review request for geode and Dan Smith. > > > Repository: geode > > > Description > ------- > > - Updating the alert level is changed from a pooled message to a serial > message. This ensures that consecutive alert level changes are > processed in the correct order. > > Also reworked the test so that we're not trying to set the same alert level > twice in a row otherwise it becomes difficult to know where the messages have > been received. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/AlertLevelChangeMessage.java > 7e6c0a4ef08cb53f16d7b024778625fbeb976cca > > gemfire-core/src/test/java/com/gemstone/gemfire/management/DistributedSystemDUnitTest.java > 193dd1222e235311413ccbb89a00ecf43e657de1 > > Diff: https://reviews.apache.org/r/40369/diff/ > > > Testing > ------- > > Ran DistributedSystemDUnitTest > > > Thanks, > > Jens Deppe > >
