You can't submit a pull request unless you create your own github fork, that's the way the github pull requests work.
A patch on the JIRA is fine too. We just need to make sure as a community we're looking at both: open pull requests - https://github.com/apache/incubator-geode/pulls JIRAs with patches - https://issues.apache.org/jira/issues/?jql=project%20%3D%20GEODE%20AND%20status%20%3D%20%22Patch%20Available%22 -Dan On Tue, Nov 17, 2015 at 1:48 PM, Nitin Lamba <[email protected]> wrote: > Thanks. I've attached the patch to the JIRA ticket as per the instructions > on the Wiki page > <https://cwiki.apache.org/confluence/display/GEODE/Code+contributions>. > > > Just curious - is it preferred to create a fork of the repo to submit a > pull request? I only have a local clone of 'incubator-geode' repo. > > > As Anthony mentioned in the Clubhouse meeting this morning, the wiki pages > do need to be merged for simplicity. > > > Best, > > Nitin > > ------------------------------ > *From:* Anthony Baker <[email protected]> on behalf of Anthony > Baker <[email protected]> > *Sent:* Tuesday, November 17, 2015 1:11 PM > *To:* Dan Smith; Dick Cavender; Mark Bretl > *Cc:* geode; Anthony Baker; Nitin Lamba > *Subject:* Re: Review Request 40395: GEODE-570 Fix javadoc gradle build > command > > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40395/ > > Ship it! > > Works on oracle jdk 1.8.0_45. javadoc target generates a few warnings but > build passes. > > > - Anthony Baker > > On November 17th, 2015, 8:02 p.m. UTC, Nitin Lamba wrote: > Review request for geode, Dick Cavender, Mark Bretl, and Dan Smith. > By Nitin Lamba. > > *Updated Nov. 17, 2015, 8:02 p.m.* > *Repository: *geode > Description > > Currently, the javadoc command errors out with JDK 8. The fix is to ignore > strict checking. > > Testing > > Tested on local dev setup. > > Diffs > > - build.gradle (a186710) > > View Diff <https://reviews.apache.org/r/40395/diff/> >
