----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40397/#review106942 -----------------------------------------------------------
Ship it! Ship It! - anilkumar gingade On Nov. 17, 2015, 8:21 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40397/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 8:21 p.m.) > > > Review request for geode, anilkumar gingade, Hitesh Khamesra, Jason Huynh, > Jianxia Chen, and Lynn Gallinat. > > > Repository: geode > > > Description > ------- > > When a member crashes we lose shared-ordered and -unordered connections. > Initiating suspect processing when this happens helps to shorten the period > of time to detect a crashed member. If the member was doing an orderly > shutdown we would receive a ShutdownMessage from it that is recorded in > GMSMembershipManager, so a check on receipt of this message can pre-empt the > new suspect processing. > > The initiation step was already in place before this change-set but it was > going directly to final verification steps which passed due to recent message > traffic from the crashed member. This change-set has GMSMemberManager use > verifyMember instead of suspectMember to check out the suspected member. > verifyMember uses a heartbeat-request first and then goes on to the final > check. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java > 551e47d713ecfb9b796708b24f416d7035bb1569 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/Transport.java > 8fcac7df51b4ce5f54e5a0205bff07d093c65bb2 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java > 79af74e715a5e482eacb78ed97009d36cca7842f > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java > 782be28f808be98f977f37491f746a33fc3c1072 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java > b6b1f8b4fdee1162a6ba1a85d982166d07e6b80b > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/ConnectionTable.java > fc14e014567889a795fa7b1caceace72e950cf91 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java > 562fd707770b005ec69d0711585c3caaf324309c > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/tcp/ConnectionJUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/40397/diff/ > > > Testing > ------- > > precheckin, integration tests > > > Thanks, > > Bruce Schuchardt > >
