----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40425/ -----------------------------------------------------------
(Updated Nov. 18, 2015, 8:44 p.m.) Review request for geode, Anthony Baker, Dick Cavender, Mark Bretl, and Dan Smith. Changes ------- Re-submitting patch after feedback Repository: geode Description ------- pulseversion.properties file is now generated from pulse gradle build file. Other older (ant) build files are removed from the repo and few pending test file cleanups. Most of the script is duplicated from gemfire-core module (thanks Mark!). Once this feature is merged into develop, we can further optimize by moving this task to the top-level project. Diffs ----- pulse/.classpath 0052fa2 pulse/.project 7c21b55 pulse/build.bat 366166e pulse/build.gradle 509ada1 pulse/build.sh 0a9f8d2 pulse/build.xml f7307a1 pulse/buildfiles/dependencies.xml 19c9224 pulse/buildfiles/osplatform.xml cc63ddf pulse/buildfiles/utilities.xml d01ab42 pulse/src/main/resources/pulseversion.properties d9c777b pulse/src/test/java/com/vmware/gemfire/tools/pulse/testbed/TestBed.java b68e0da pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTests.java 3401394 pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/junit/BaseServiceTest.java e98cdda Diff: https://reviews.apache.org/r/40425/diff/ Testing ------- Tested on the local machine - see attached screenshot. UI layout needs a bit of fixing, which will be picked-up with GEODE-511 (Fixing license headers and branding). File Attachments (updated) ---------------- Pulse Screenshot https://reviews.apache.org/media/uploaded/files/2015/11/18/592e89d0-0c7e-4983-874c-cf52c6d4f598__Screen_Shot_2015-11-17_at_7.04.50_PM.png Updated Diff https://reviews.apache.org/media/uploaded/files/2015/11/18/1e81b7e7-249a-48d3-8cbe-de464a85f65f__patch.diff Thanks, Nitin Lamba
