The GEODE-18 is helped by external committers; the initial changes were to update the individual files; now the work/change is complete, its time to make this as part of build; so that new files are not merged without the header/agreements...
-Anil. On Wed, Nov 25, 2015 at 3:13 PM, Kirk Lund <[email protected]> wrote: > GEODE-18 was supposed to include adding RAT to our build. Not sure what > happened but GEODE-608 is more specific. > > -Kirk > > On Wednesday, November 25, 2015, Nitin Lamba <[email protected]> wrote: > > > +1 > > > > Maybe it is obvious but having RAT as part of pre-checkin step would be > > desirable. > > > > -Nitin > > > > ________________________________________ > > From: Anthony Baker <[email protected] <javascript:;>> > > Sent: Wednesday, November 25, 2015 11:41 AM > > To: [email protected] <javascript:;> > > Subject: Re: License headers on new source files > > > > Issue created: GEODE-608 > > > > Anthony > > > > > On Nov 25, 2015, at 11:16 AM, Roman Shaposhnik <[email protected] > > <javascript:;>> wrote: > > > > > > Honestly, I though you guys integrated RAT already. > > > > > > Not that it is a rule or anything, but for any Java-based > > > project the easiest way to entice mentors to review > > > your stuff is to provide RAT integration via the build > > > system. > > > > > > I'd say this is close to a must before our first release. > > > > > > Thanks, > > > Roman. > > > > > > On Tue, Nov 24, 2015 at 8:12 PM, William Markito <[email protected] > > <javascript:;>> wrote: > > >> Here is the Apache RAT graded plugin for the checks: > > >> > > >> https://plugins.gradle.org/plugin/org.nosphere.apache.rat > > >> > > >> Sent from my iPhone > > >> > > >>> On Nov 24, 2015, at 3:52 PM, Jacob Barrett <[email protected] > > <javascript:;>> wrote: > > >>> > > >>> There are plugins for gradle that check for copyright and license > > headers. They can be configured to fail the build if they are missing > from > > any files. It would be a good way to make sure all files have the > headers. > > >>> > > >>> > > >>> > > >>> > > >>> -Jake > > >>> > > >>> > > >>> > > >>> > > >>> > > >>> > > >>> > > >>> — > > >>> > > >>> Jacob Barrett > > >>> Manager > > >>> GemFire Advanced Customer Engineering (ACE) > > >>> Pivotal > > >>> > > >>> [email protected] <javascript:;> > > >>> 503-533-3763 > > >>> > > >>> For immediate support please contact Pivotal Support at > > http://support.pivotal.io/ > > >>> > > >>>> On Tue, Nov 24, 2015 at 3:05 PM, Anthony Baker <[email protected] > > <javascript:;>> wrote: > > >>>> > > >>>> Niall points out on GEODE-18 that new files are being added without > > the appropriate license header. Please make sure any new files have the > > ASL header at the top. > > >>>> Here’s the snippet to use: > > >>>> /* > > >>>> * Licensed to the Apache Software Foundation (ASF) under one or more > > >>>> * contributor license agreements. See the NOTICE file distributed > > with > > >>>> * this work for additional information regarding copyright > ownership. > > >>>> * The ASF licenses this file to You under the Apache License, > Version > > 2.0 > > >>>> * (the "License"); you may not use this file except in compliance > with > > >>>> * the License. You may obtain a copy of the License at > > >>>> * > > >>>> * http://www.apache.org/licenses/LICENSE-2.0 > > >>>> * > > >>>> * Unless required by applicable law or agreed to in writing, > software > > >>>> * distributed under the License is distributed on an "AS IS" BASIS, > > >>>> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > > implied. > > >>>> * See the License for the specific language governing permissions > and > > >>>> * limitations under the License. > > >>>> */ > > >>>> Anthony > > > > >
