> On Dec. 1, 2015, midnight, Mark Bretl wrote: > > Was 'findbugsMain' task run for testing?
Yes, I ran findbugsMain. It generated a report of warnings, etc. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40784/#review108418 ----------------------------------------------------------- On Nov. 29, 2015, 4:28 p.m., Anthony Baker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40784/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2015, 4:28 p.m.) > > > Review request for geode, Mark Bretl and Dan Smith. > > > Repository: geode > > > Description > ------- > > Swtich the findbugs annotation dependency to use an ASL version > from https://github.com/stephenc/findbugs-annotations. This > library only supports the SuppressWarning annotation, not > SuppressFBWarning so some source files were updated. > > > Diffs > ----- > > build.gradle b5465b8eeb14408bae1624c8ffe7f25b4863e2b2 > gemfire-core/build.gradle dd3b765d31fac624d939045794bd77391a52bb6f > gemfire-core/src/main/java/com/gemstone/gemfire/SystemFailure.java > 494f5f7ec3ddb33f2bf2abf202bc1d5c05ea668a > > gemfire-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/AgentImpl.java > 4d1ad41c96772a4b40d7166422696cb2d7791ee1 > > gemfire-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/GemFireHealthConfigJmxImpl.java > c05d4b8c69b7dd393efb8f91d290a48c0fe4fbbc > > gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/CompiledOperation.java > d9f0d6c53179068f02740f8d89c4c5b8f52e4b43 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/StatArchiveWriter.java > 562cce34de85b6b4674457776e1427a61e37207b > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractUpdateOperation.java > 3ac006b197fa1114713343b5a518929b40e6fe7b > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/TXStateProxyImpl.java > fda1a3ad58cb5bac228ceb1b9c3d72c2aaa70298 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImpl.java > 89c073fd3bd366ba47f11dde56b034b8d92f57d0 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/BaseCommand.java > 52ea6f55b55a656bdb02fb192c6d49ca309e07f8 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/ClientProxyMembershipID.java > daa07f482e9cf9b0d7ae0492e450d62795c62dec > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionVector.java > 61423d137b6788581001fe1f7bcc858f044bf33d > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/datasource/AbstractPoolCache.java > b615327971edbe51b232211ac57bf35dee4b51e0 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/memcached/commands/GetCommand.java > 8fd08479ea4cda035fc41cfd10201b284eef5de3 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/statistics/SampleCollector.java > 9b40e95b386370dd6b5e72a4bca956e6e97f3102 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/util/DebuggerSupport.java > 49ce32e8dd92be2a34057969411eeb4acc6f95f3 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/util/SingletonValue.java > 5f902b69576e14db8ceb5f05a52da2896968b0e7 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/util/concurrent/CustomEntryConcurrentHashMap.java > 75dc330ea6ca38ccafc63328acc8c0693703bc47 > gradle/dependency-versions.properties > 3e6b6a511eac6992f2d0b114cc9c1ee002d7cce8 > > Diff: https://reviews.apache.org/r/40784/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Baker > >
