----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40845/#review108585 -----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorImpl.java (line 244) <https://reviews.apache.org/r/40845/#comment168037> change "alll" to "all" - Darrel Schneider On Dec. 1, 2015, 3:36 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40845/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2015, 3:36 p.m.) > > > Review request for geode and Eric Shu. > > > Bugs: GEODE-607 > https://issues.apache.org/jira/browse/GEODE-607 > > > Repository: geode > > > Description > ------- > > Added SimpleMemoryAllocatorImpl code coverage. > Cleaned up ChunkType. It is now an interface and removed some dead methods on > it. > Removed some sqlf dead code. > Refactored duplicate code into AbstractStoredObject > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/AbstractStoredObject.java > PRE-CREATION > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/Chunk.java > e32a1c6959f9fced5eaa2b6d8f0cf7e5f7194537 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/ChunkType.java > 9841368f8d99204a9795ee2363766f44798703ce > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/DataAsAddress.java > 61204ba9de95a46f6f9fcac681aa8b1e7ffad998 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/Fragment.java > bd05ddb086fc26be852b79f2a5f33000e2a9277c > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java > 48a0756ee1df3b05ea90dbbee108199ad30bfd48 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/GemFireChunk.java > 3167613c6ffbbd6ef74994ee1598ac947d6435b4 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryAllocator.java > 231ff3a60d33677f61e220c209dbed5ed49228f1 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryBlockNode.java > 3f5f4dc1ef31285f09285ea15f55a9fdc5d8ab02 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryInspector.java > acf6d042ebc684bb9150ae34a196a419effa9b8d > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapCachedDeserializable.java > 143fb25d48d1e89b84b47c2119a3ec2c13e87b20 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java > 1a6cc8bcda68ac8870bbd69943691d67b910a1e4 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorImpl.java > f16253e3bd8da0eb4eec1b49b280deb4ab3f9eeb > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/UnsafeMemoryChunk.java > 06fee7bb11b301e57894f4a404aa1de057f632ec > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/NullOffHeapMemoryStats.java > 7c668f1693ccaf1d00e0a5ebad68fde05c7bf557 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/NullOutOfOffHeapMemoryListener.java > caa913a3fbe0134038fe3af84054a6a530ab56d8 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorJUnitTest.java > 19dfebb6cf8bf4c019b4ea6b2b39f0ec8538db2e > > Diff: https://reviews.apache.org/r/40845/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > >
