----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40871/#review108702 -----------------------------------------------------------
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunctionJUnitTest.java (line 96) <https://reviews.apache.org/r/40871/#comment168161> Better would be to get rid of the "system" and just create a cache. In tearDown call "this.cache.close()". This will also disconnect the DS that the cache owns. Here is the cleanest code to create the cache (no need for a Properties object): this.cache = new CacheFactory().set(DistributionConfig.MCAST_PORT_NAME, "0").create(); - Darrel Schneider On Dec. 2, 2015, 11:07 a.m., Jens Deppe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40871/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2015, 11:07 a.m.) > > > Review request for geode, Barry Oglesby and Darrel Schneider. > > > Repository: geode > > > Description > ------- > > GEODE-184: The gfsh 'locate entry' command fails to find the entry on > partitioned regions if the key is not a string > > The bug report states exactly what the fix is. I'm also adding a test. Any > ideas on how to make this a less heavy test would be good. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java > d4dac05d7cfe9f775bdc1918c8d4621b1ae1bbb6 > > gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunctionJUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/40871/diff/ > > > Testing > ------- > > Ran distributedTest task > > > Thanks, > > Jens Deppe > >
