> On Dec. 4, 2015, 12:47 a.m., Bruce Schuchardt wrote: > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java, > > line 462 > > <https://reviews.apache.org/r/40886/diff/1/?file=1151860#file1151860line462> > > > > add socket.close() to this and other test methods creating sockets?
Thanks Bruce, I ended up using a try-with-resources statement from java 8. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40886/#review108921 ----------------------------------------------------------- On Dec. 2, 2015, 11:15 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40886/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2015, 11:15 p.m.) > > > Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh > Khamesra, Jianxia Chen, and Lynn Gallinat. > > > Repository: geode > > > Description > ------- > > Adding additional unit tests > minor refactoring to allow testing > Moved GMSHealthMonitorJUnitTest to package level that corresponds with > GMSHealthMonitor > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java > 10478b7 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java > fcda1a0 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 2f9c514 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java > e49e4ae > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/fd/GMSHealthMonitorJUnitTest.java > 41a99a6 > > Diff: https://reviews.apache.org/r/40886/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
