----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40997/ -----------------------------------------------------------
Review request for geode, anilkumar gingade, Hitesh Khamesra, Jason Huynh, Jianxia Chen, and Lynn Gallinat. Repository: geode Description ------- Additional unit tests for JGroupsMessenger. Code coverage for this class is now > 88%. I also added code coverage for the message classes. Coverage for them is now 70-90%. There is also some work in DUnitLauncher and ProcessManager to try to get DUnit ChildVMs to report their coverage data to EclEmma (JaCoCo for Eclipse). Diffs ----- gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java 23f9dee7da6e571f15d809325c55e577a9e48016 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/MemberAttributes.java 7cd89d778d6aa453c1dcb8ae9b31a710a7cf1d1c gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 2f9c5140ce566749f8972ae89bf5763c617fa29a gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/HeartbeatMessage.java a116913c4ac45423b486f2f12bb0a88eab97b13c gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/HeartbeatRequestMessage.java f7e1009f26001f6fafea80716eb72629c80e2f97 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/InstallViewMessage.java 8d4cb4e3887d8256572f95dc6626d85147ad4b11 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/JoinResponseMessage.java df1b3f6626a86f1a5fab8a4a91d1f3bd04c5c138 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/ViewAckMessage.java 00f31d68c4cfbdfb1ad4940ff194aef07718e905 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/AddressManager.java 0fd1c6e7c9d404a12f589a54bf1db206ec960a36 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSPingPonger.java fb32254f786e2e8a25a3c03047835dc997168ec5 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGAddress.java 1380eb2752aaec1f10801ed3c8c31778fe16bd22 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 4e68b630e3838cc08602091d496711c1e72a6ab9 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/Transport.java 8ba59b6c183adfc9c8908cec97be9fff4ac0c870 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServer.java 516fe8d77615f2fb0e09f3a4419b2b84c48d63f3 gemfire-core/src/main/java/com/gemstone/gemfire/internal/i18n/ParentLocalizedStrings.java 150b40836deced8041ffa89b93cb7f36fc57283e gemfire-core/src/test/java/com/gemstone/gemfire/cache30/ReconnectDUnitTest.java dd6f1fa1fb4602e954aebe15c716a4d4ee17975b gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionManagerDUnitTest.java 82dfdb7bace82f8f27c21e964a3b7ae88ec3d9b9 gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/MembershipJUnitTest.java 2ce1ca77fef29862a5dd5933af24b0329dece1d9 gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/MembershipManagerHelper.java c5141de9f77b6ad7d931ec66f0870e952a254b00 gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java fbdcdf5128408c758ba73d657a343282391eb225 gemfire-core/src/test/java/dunit/RemoteDUnitVMIF.java 00042463e26f25cabef04395ae0f79aa0f05d796 gemfire-core/src/test/java/dunit/standalone/ChildVM.java 67b2710d6cdbacc91ca03a914f8adf57bd5f0e76 gemfire-core/src/test/java/dunit/standalone/DUnitLauncher.java f3109f3cfbae65126abe5d5fd55356873a1ee778 gemfire-core/src/test/java/dunit/standalone/ProcessManager.java 60ac04d2f063141750004035303c4e290c28e3ce gemfire-core/src/test/java/dunit/standalone/RemoteDUnitVM.java 15acc2eb6c45c44fbca34a260f56ccf7984561ea Diff: https://reviews.apache.org/r/40997/diff/ Testing ------- precheckin is underway Thanks, Bruce Schuchardt
