> On Dec. 7, 2015, 11:30 p.m., Ashvin A wrote: > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/AsyncEventQueueTestBase.java, > > line 75 > > <https://reviews.apache.org/r/41058/diff/1/?file=1155446#file1155446line75> > > > > Do these test classes need to be put in a test category?
I don't see any of our other dunit tests added to a category right now. I don't think the categories work for the dunit tests, because they are still using the junit 3 framework. We're just categorizing the junit tests right now. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41058/#review109221 ----------------------------------------------------------- On Dec. 7, 2015, 11:24 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41058/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2015, 11:24 p.m.) > > > Review request for geode, Ashvin A and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > GEODE-637: Additional tests for AsyncEventQueues > > > Diffs > ----- > > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/AsyncEventQueueTestBase.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerOffHeapDUnitTest.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventQueueStatsDUnitTest.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentAsyncEventQueueDUnitTest.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentAsyncEventQueueOffHeapDUnitTest.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/CommonParallelAsyncEventQueueDUnitTest.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/CommonParallelAsyncEventQueueOffHeapDUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/41058/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
