----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41110/ -----------------------------------------------------------
(Updated Dec. 9, 2015, 8:11 p.m.) Review request for geode and Darrel Schneider. Changes ------- Added more tests to cover AbstractStoredObject. * Refactored AbstractStoredObject to add protected create methods. Repository: geode Description ------- * Refactored DataAsAddress and OffHeapRegionEntryHelper to make it testable * Renamed encodedAddress* methods to decodeAddressTo* * Added DataAsAddress JUnit tests Diffs (updated) ----- gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/DataAsAddress.java 5b14389b8925efe6910ce51c9b55aafd9270201b gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java d1a81f0a9409d0f6683ee4e4a4546c2d2e58fe6a gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/offheap/AbstractStoredObjectTestBase.java PRE-CREATION gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/offheap/DataAsAddressJUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/41110/diff/ Testing (updated) ------- precheckin Thanks, Sai Boorlagadda
