----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41419/#review110765 -----------------------------------------------------------
Ship it! gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/HandShake.java (line 1313) <https://reviews.apache.org/r/41419/#comment170768> This can be excluded from check in, since there is only whitespace change. - Jianxia Chen On Dec. 16, 2015, 8:14 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41419/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 8:14 p.m.) > > > Review request for geode and Jianxia Chen. > > > Repository: geode > > > Description > ------- > > ClientProxyMembershipID was modified to always deserialize its > DistributedMember component with version GFE_82, but this caused it to report > that the client was using version GFE_82 & that is not necessarily the case. > > This change reverts that modification and has fromData look for the version > in the DataInput stream. InternalDistributedMember's fromData method then > checks for EOFException for cases where the ClientProxyMembershipID was > transmitted from an 8.2 client or WAN site but the version wasn't known > (which is the case during a client/server handshake). > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java > b112b9241793a7a02386a0ddad50aa0a0e16ad9e > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/NetMember.java > 681107382270b91ed72c0691499d8480dbe3d973 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java > b1a48835002c7c16ba7d1ae2517593e0e3d1a246 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/ClientProxyMembershipID.java > daa07f482e9cf9b0d7ae0492e450d62795c62dec > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/HandShake.java > be3a7bf344b1e74b3aaa31a7c4d3229b268d5bd5 > > gemfire-core/src/test/java/com/gemstone/gemfire/cache/client/ClientCacheFactoryJUnitTest.java > d15863b161d5858a90b3079bf31293cc17cad07d > > gemfire-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedDataSerializables.txt > d553ad9493f9238a45eb040ebfd3b8fe9dee07c0 > > Diff: https://reviews.apache.org/r/41419/diff/ > > > Testing > ------- > > passes the integration test that was failing prior to the change I am > partially reverting. The changes to HandShake from that commit are still in > place. > > > Thanks, > > Bruce Schuchardt > >
