> On Dec. 17, 2015, 1:04 a.m., Kirk Lund wrote: > > I recommend introducing PowerMock on dev@geode before committing this. > > Also, it would be good to have some general guidelines regarding when and > > how to use PowerMock. I haven't used it before, but I've seen enough > > negative sentiment towards it online that we should probably use it as a > > last resort or as a temporary measure while encouraging refactoring for > > testability in the long run.
Kirk, do you have comments on the code itself? It doesn't seem like there is any negative sentiment to using PowerMock. - Jens ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41481/#review110821 ----------------------------------------------------------- On Dec. 17, 2015, 12:26 a.m., Jens Deppe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41481/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 12:26 a.m.) > > > Review request for geode and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-660: Fixing inconsistencies and reliance on randomness in > TableBuilderJUnitTest > > Introduced mocking and added additional tests making it completely > deterministic. > > > Diffs > ----- > > gemfire-core/build.gradle 19aeee183f0e132f3f0a12d71e96988ab67673df > > gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/result/TableBuilder.java > d2363de216ad036381556172bf515f691297ce9f > > gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/result/TableBuilderHelper.java > 32fa04853c9800a4bdb53cc0268a5e001fa63b64 > > gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/TableBuilderJUnitTest.java > e5f1d86ba2f2eb006ba15d65ad9c78415a4bd2ff > gradle/dependency-versions.properties > 8ea38c3b1d6cdc573d356158b0d350ec47a4cea7 > > Diff: https://reviews.apache.org/r/41481/diff/ > > > Testing > ------- > > > Thanks, > > Jens Deppe > >
