----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41694/#review112085 -----------------------------------------------------------
Ship it! A couple of very minor changes & you can check it in. I don't think the changes require retesting. gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java (line 142) <https://reviews.apache.org/r/41694/#comment172396> delete gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionStats.java (line 354) <https://reviews.apache.org/r/41694/#comment172395> this should say 'received' instead of 'sent' - Bruce Schuchardt On Dec. 28, 2015, 7:50 p.m., Jianxia Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41694/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2015, 7:50 p.m.) > > > Review request for geode, anilkumar gingade, Bruce Schuchardt, Darrel > Schneider, Hitesh Khamesra, and Jason Huynh. > > > Repository: geode > > > Description > ------- > > Implementation for Geode membership health monitor with unit tests > Refactor the health monitor code a little bit (rename variables and remove > unnecessary code) > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DMStats.java > e79a40b > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionStats.java > 804b507 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/LonerDistributionManager.java > 60158d1 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java > 005b0ed > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java > d539374 > > Diff: https://reviews.apache.org/r/41694/diff/ > > > Testing > ------- > > > Thanks, > > Jianxia Chen > >
