> On Dec. 30, 2015, 9:51 p.m., Dick Cavender wrote: > > The NOTICE file that ships with the sources is going to be different than > > the one that ships with the binary so there still may be work to do on this > > where one is excluded while the other isn't in this distribution.
Yep. The NOTICE file for the binary should be placed at gemfire-assembly/src/main/dist. The version for the src distribution can remain at the project root or be moved to gemfire-assembly/src/src/dist. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41801/#review112349 ----------------------------------------------------------- On Dec. 30, 2015, 3:12 p.m., Anthony Baker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41801/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2015, 3:12 p.m.) > > > Review request for geode, Dick Cavender, Jens Deppe, and Dan Smith. > > > Repository: geode > > > Description > ------- > > GEODE-627: Add source distribution > > Add another distribution to create source archives, without gradle > wrapper binaries included. > > > Diffs > ----- > > gemfire-assembly/build.gradle 373d77a > > Diff: https://reviews.apache.org/r/41801/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Baker > >
