----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42045/#review113388 -----------------------------------------------------------
Thanks for cleaning up that the Puts thread stuff. However, I'm not sure this is the right fix. The issue is that you have an asynchronous thread that is closing the cache, and that thread is still operating after your test method finishes, correct? So you have no idea when that thread will actually complete ... maybe even in the middle of the next test. It seems like it would be better to wait for that thread to finish in your test method. - Dan Smith On Jan. 8, 2016, 12:35 a.m., Shreedhar Hardikar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42045/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 12:35 a.m.) > > > Review request for geode, Ashvin A and Dan Smith. > > > Repository: geode > > > Description > ------- > > Improper clean up of a test directory causes a DiskAccessException when > creating a region. That also causes the cache to close asynchronously, > raising a CacheClosedException during test tearDown. > > Minor refactoring: > > * Moved putSuccessful and exceptionOccurred inside Puts > > * Remove unnecessary thread creation for Puts in DiskRegionJUnitTest > > > Diffs > ----- > > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/DiskRegionJUnitTest.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/DiskRegionTestingBase.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/42045/diff/ > > > Testing > ------- > > ./gradlew gemfire-core:integrationTest > -DintegrationTest.single=DiskRegionJUnit Passes > > The bug was reproduced by adding another test that loop through multiple > calls to testSingleDirectorySizeViolation() as suggested at > https://cwiki.apache.org/confluence/display/GEODE/Tips+and+Tricks+for+fixing+DUnit+test+failures. > That also passed after this fix. > > > Thanks, > > Shreedhar Hardikar > >
