----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42198/#review114011 -----------------------------------------------------------
Looks pretty good. Rather than invoking gpg from the command line, I think it would be better to use the built in gradle signing plugin: https://docs.gradle.org/current/userguide/signing_plugin.html - Dan Smith On Jan. 12, 2016, 4:48 p.m., Anthony Baker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42198/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 4:48 p.m.) > > > Review request for geode, Dick Cavender, Nitin Lamba, and Dan Smith. > > > Repository: geode > > > Description > ------- > > The binary and source distributions created by the build need > accompanying hash files to verification. This change uses the > doList hook to generate the hashes after the distribution is > created. > > GEODE-775: Add build support to easily sign a distribution > > Setting `-Psign=true -Pkey=XXX` will create a detached signature > file for each distribution. The gpg command must be installed > and the selected key present on the keyring. > > > Diffs > ----- > > gemfire-assembly/build.gradle ad466de1eb653e61ad93e1b78c164124addb2009 > gradle.properties 3687ff0645456eb35ead8402239e111821b50a8c > > Diff: https://reviews.apache.org/r/42198/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Baker > >
