----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41492/#review115474 -----------------------------------------------------------
Ship it! Ship It! - xiaojian zhou On Jan. 16, 2016, 1:45 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41492/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2016, 1:45 a.m.) > > > Review request for geode, Ashvin A and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > The eventQueueSize stat has issues with concurrent events during start > and stop that are leading it to be inaccurate. To make gfsh and jmx > correct, measuring the queue size directly from the underlying region > size. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/cache/asyncqueue/internal/ParallelAsyncEventQueueImpl.java > 377f8e282e2b86e0dddefd485d5708e424088eed > > gemfire-core/src/main/java/com/gemstone/gemfire/cache/asyncqueue/internal/SerialAsyncEventQueueImpl.java > 8c8342c7869a6fb4315a544bbf42411be742b908 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java > 422c150fbf1e34785f79bbad54b52cd61594e64c > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java > b9d877e1a0fab318ae8c29e8ea076bf4d42fb051 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderAdvisor.java > 60ed6c819f36e15f158e96bfdeb8f5c90962ef2c > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderEventProcessor.java > 8d11079982af02c2583de3484bd8dbbf9111a135 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java > 94dc9e8708df08221d26791dd53ab0070657afae > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueueJUnitTest.java > PRE-CREATION > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/ConcurrentSerialGatewaySenderEventProcessor.java > 16410cec806618eff49a3a4611e257cbfa8278a6 > > gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/beans/GatewaySenderMBeanBridge.java > 0b6f4325998b56ba03ede0dc01350f941c7e606b > > gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/beans/stats/StatsKey.java > 50972923b5ff4842822ba30d039bb5c56f66509f > > gemfire-core/src/test/java/com/gemstone/gemfire/cache/hdfs/internal/SortedListForAsyncQueueJUnitTest.java > bfd4ac38670a9e651d34803912d2eaf0a9a76703 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/ConcurrentSerialGatewaySenderEventProcessorJUnitTest.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/management/bean/stats/GatewaySenderStatsJUnitTest.java > 30b3a82f7a96773f6414d933f49b5da8090dc7ad > > Diff: https://reviews.apache.org/r/41492/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
