> On Jan. 20, 2016, 6:37 p.m., Dan Smith wrote: > > I'm not sure we need to support upgrading from 6.6.4. Even pivotal doesn't > > support 6.6 any more. My preference would be to not add this test if it's > > introducing nastyness to the build.
Thanks Dan. I'm just going to remove the original test from the closed side then. - Jens ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42261/#review115452 ----------------------------------------------------------- On Jan. 20, 2016, 3:07 p.m., Jens Deppe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42261/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2016, 3:07 p.m.) > > > Review request for geode and Dan Smith. > > > Repository: geode > > > Description > ------- > > GEODE-779: Adding upgrade offline diskstore unit test > > This test has mostly (the main logic) been migrated from the closed source > side. Much of the old code was dead and has been removed. > > The test has also been converted from DUnit to JUnit. > > One unusual aspect is that the test relies on running an older version of > GemFire (6.6.4). This is achieved by creating a 'gemfire664' configuration > (in Gradle) and setting a special system property, containing the correct > classpath, which the test then utilizes. Any other suggestions on how to > approach this would be welcome! > > > Diffs > ----- > > build.gradle 13b2f33be75a9e1ab9981a473ef0d46521df8a49 > gemfire-core/build.gradle 3e3c19bd779619f7e5d44cf4a192eb2bc3e64243 > > gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java > a0fb8f8e8f4d485d88799acb8ec1a72a40972af0 > > gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/UpgradeOfflineDiskStoreJUnitTest.java > PRE-CREATION > gradle/dependency-versions.properties > 0bbbccd10b3a5c1e951b3314da82f49dfd899ecf > > Diff: https://reviews.apache.org/r/42261/diff/ > > > Testing > ------- > > > Thanks, > > Jens Deppe > >
