Thanks Jinmei.

I tried running Pulse UI tests but ran into few issues, listed below:

1. Firefox version has been updated so Selenium jars also requires a new version
2. During the process of cleaning-up build.gradle, setting-up test 
environmental variables was removed

I submitted a review request/ patch for these [1]. Few other clean-up tasks 
below:

3. Only 'PulseAutomatedTests' needs to be run for UI. Based on test 
inheritance, those tests run correctly and only once. The rest of the tests, 
especially for back-end service are too old, should be ignored. [2] has some 
good background on this topic from last year

4. In addition to updating the NOTICE/ LICENSE files, the build.gradle file 
should have hard-coded versions removed and inherited from a separate 
properties file, just like the main project .gradle file

- Nitin
[1] https://reviews.apache.org/r/42659/
[2] https://issues.apache.org/jira/browse/GEODE-304

________________________________________
From: Jinmei Liao <[email protected]>
Sent: Thursday, January 21, 2016 9:53 PM
To: [email protected]
Subject: Re: Pulse UI merged to develop

To run all the UI tests, you just do "./gradlew uiTest" in the command
line. Currently these tests are not run in Jenkins since it would require
Firefox to be launched. All the PulseAutomatedTest, PulseBaseTest and
PulseTest are run as uiTest.

licenses are updated on each file. Will update the LICENSE and NOTICE as
well.

As to the branding, I believe we will still leave Jira around to capture
the work to be done.

On Thu, Jan 21, 2016 at 5:43 PM, Nitin Lamba <[email protected]> wrote:

> Great progress - thanks Jinmei and Jens!
>
> Tried to build 'develop' on my machine and started Pulse - launched as
> expected. How does one launch UITests? I see those tests removed form
> build.gradle file that were worked on last year.
>
> As mentioned, Pivotal/ Gemfire branding on the UI is still not fixed - see
> attached. Per the JIRA[1], licensing was worked on a bit last November but
> haven't seen any recent updates. The top-level JIRA (GEODE-12) captures all
> the pending items - still a few unresolved.
>
> Ideally, shouldn't all the issues be addressed before merging into develop?
>
> - Nitin
> [1] https://issues.apache.org/jira/browse/GEODE-511
>
> ________________________________________
> From: Jinmei Liao <[email protected]>
> Sent: Thursday, January 21, 2016 3:32 PM
> To: [email protected]
> Subject: Re: Pulse UI merged to develop
>
> Oh, no, not yet. But all the sources brought over has the corresponding
> license headers, and gradle rat is running successfully. Will update those
> LICENSE/NOTICE soon.
>
> On Thu, Jan 21, 2016 at 3:29 PM, Anthony Baker <[email protected]> wrote:
>
> > Excellent!  Have the LICENSE / NOTICE files been updated based on the new
> > source and binary dependencies?
> >
> > Anthony
> >
> > > On Jan 21, 2016, at 3:15 PM, Gregory Chase <[email protected]> wrote:
> > >
> > > + dev
> > >
> > > On Thu, Jan 21, 2016 at 3:12 PM, Jens Deppe <[email protected]>
> > wrote:
> > >
> > >> Thanks to the work of Jinmei and Nitin, we now have the Geode Pulse UI
> > >> merged to develop!
> > >>
> > >> This does not bring any new features with it, but does make the UI
> > >> automatically available when starting a locator. More information
> about
> > >> accessing Pulse can be found here:
> > >>
> >
> http://gemfire.docs.pivotal.io/docs-gemfire/latest/tools_modules/pulse/chapter_overview.html
> > >>
> > >> This does mean that Jiras can (and should) be filed against found bugs
> > and
> > >> for new features you would like to see in Pulse.
> > >>
> > >> After today's nightly build, you can download a distribution here to
> try
> > >> it out: https://builds.apache.org/job/Geode-nightly/
> > >>
> > >> --Jens
> > >>
> > >
> > >
> > >
> > > --
> > > Greg Chase
> > >
> > > Director of Big Data Communities
> > > http://www.pivotal.io/big-data
> > >
> > > Pivotal Software
> > > http://www.pivotal.io/
> > >
> > > 650-215-0477
> > > @GregChase
> > > Blog: http://geekmarketing.biz/
> >
> >
>
>
> --
> Cheers
>
> Jinmei
>



--
Cheers

Jinmei

Reply via email to