GitHub user pdxrunner opened a pull request:

    https://github.com/apache/incubator-geode/pull/77

    Feature/geode 735

    Added OffHeapHelperJUnitTest class

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pdxrunner/incubator-geode feature/GEODE-735

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #77
    
----
commit eb26697a83198665d0063c32c4852293a67bf673
Author: Ken Howe <[email protected]>
Date:   2016-01-19T20:40:13Z

    GEODE-735: Create JUnit tests for 
com.gemstone.gemfire.internal.offHeap.OffHeapHelper class
    
    The OffHeapHelper class had no targeted unit tests and had low
    coverage through existing test suites. This new JUnit test class
    completly covers all of the static helper functions in OffHeapHelper.

commit a1d92919520a2c5d33a2754aa642957d8ad89f95
Author: Hitesh Khamesra <[email protected]>
Date:   2016-01-08T00:06:43Z

    GEODE-412 We were re-setting the value count after getting its value.
    Sepatrated that logic as test may look this count more than once.

commit aeea8eda4737cb635bf268db804b756ce70c0be0
Author: Kirk Lund <[email protected]>
Date:   2015-12-28T21:44:38Z

    GEODE-714: Modify all tests to use JUnit Categories
    
    * Add DistributedTest @Category to DistributedTestCase
    * Rename disabled tests and use @Ignore instead.
    * Add ContainerTest, HydraTest categories.
    * Ensure ever *Test has a @Category.
    * Disable performance tests that perform no assertions.
    * Modify build to check all tests for categories.
    * Modify build to use **/*Test.class pattern for all testing tasks.
    * Modify DUnitLauncher to get name of ChildVM.class from the class itself.

commit 4c9ee53dfd352fbfad58ee96dbca3a962ceeafeb
Author: Jason Huynh <[email protected]>
Date:   2016-01-06T17:55:49Z

    GEODE-245: QueryMonitor cancellation is being ignored by query using 
CompactRangeIndex
    Fixed QueryMonitor test hook to pause at the correct point in code

commit 42578cee91a96d7d784e57a1974766b7e4138a14
Author: Darrel Schneider <[email protected]>
Date:   2016-01-07T00:57:26Z

    GEODE-701: fix double free in unit test
    
    The failure was caused by LifecycleListenerJUnitTest setting
    a system property and then not unsetting it when it completed.
    testClose now asserts that the system property must be initially
    false when it runs.
    LifecycleListenerJUnitTest now unsets the property in a finally
    block after setting it.

commit a5cdcfe6c66ffab0d8ec2004600f40936f09b98b
Author: Karen Miller <[email protected]>
Date:   2016-01-07T23:53:50Z

    GEODE-769  Update 3 issues in README.md

commit e5cb1a3070582c7ae20d283239fd4acc8e91bd8c
Author: Hitesh Khamesra <[email protected]>
Date:   2016-01-08T00:10:19Z

    GEODE-452:We don't send client close response from server thus we need to
    wait for client termination before validating the HAStatsCleanup.

commit e3b33d604eb6bc005568a6dbfddc3b5fa3d14663
Author: Bruce Schuchardt <[email protected]>
Date:   2016-01-08T17:58:27Z

    GEODE_368: CI failure in 
HARQueueNewImplDUnitTest.testConcurrentGIIAndDispatch
    
    removed an old assertion that is no longer valid and rewrote the code to
    allow for the possibility of a null entry in the queue.
    
    This commit also includes renaming of one of the old BugXXX unit test 
classes
    that I'm currently working on to have a name that matches what it is 
testing.

commit 70b5b061842378cbf45e6a61988ad84cd68b6081
Author: Jason Huynh <[email protected]>
Date:   2016-01-08T18:22:09Z

    GEODE-771: PdxGroupByPartitionedQueryDUnitTest.testCompactRangeIndex failed 
with AssertionFailedError
    Order by needs to be specified in the query

commit 9876f057844b9c05336875db6c87dcdd6a83c45e
Author: Bruce Schuchardt <[email protected]>
Date:   2016-01-08T18:46:31Z

    GEODE-364: CI failure in SingleHopStatsDUnitTest.testClientStatsPR
    
    This failure could also happen with the other test in this class:  a
    client does put() operations that force the scheduling of a fetch of
    PR metadata.  The client asserts that the metadata has been fetched,
    but since the fetching is asynchronous it's possible for the client
    to complete its put() operations and execute the assertion before the
    asynchronous operation has completed.
    
    The fix adds a WaitCriterion for the assertion.

commit f05152fc382b9bbefb491d02cc5827f0fa28b74e
Author: Bruce Schuchardt <[email protected]>
Date:   2016-01-08T23:03:43Z

    Geode-561: DistributedNoAckRegionCCEDUnitTest.testTombstones
    
    Due to the batched nature of tombstone garbage-collection it's possible
    that only a small portion of the tombstones in this test will be removed.
    The test has been changed to stop expecting that all tombstones will
    be removed.

commit 948646d50bb2ef0a8c9682ac41e34df25269cb09
Author: Darrel Schneider <[email protected]>
Date:   2015-12-08T22:49:48Z

    GEODE-643: improve UnsafeMemoryChunk unit test coverage

commit 32306aac0105995a3b7f4ac1ed9b9320f725338a
Author: Bruce Schuchardt <[email protected]>
Date:   2016-01-08T23:35:44Z

    fixed GEODE-767: GMSJoinLeaveJUnitTest.testNoViewAckCausesRemovalMessage
    
    The test was not waiting for background suspect processing to take place
    and had a faulty verification check.

commit 181c3f0f3ed957ce463da91223644954c66503c1
Author: Kirk Lund <[email protected]>
Date:   2016-01-11T20:10:17Z

    GEODE-766: Ignore gemfire.properties file and convert to JUnit 4

commit f705e79af38e5ad39c8437b34e3f85893fd22d57
Author: Kirk Lund <[email protected]>
Date:   2016-01-11T20:17:29Z

    GEODE-765: Ignore gemfire.properties file and convert to JUnit 4

commit 86802b9ad6c4034031cf5687b69d37ca400a9c5a
Author: Anthony Baker <[email protected]>
Date:   2016-01-12T15:41:35Z

    GEODE-775: Generate md5 / sha-256 hashes for the distributions
    
    The binary and source distributions created by the build need
    accompanying hash files to verification.  This change uses the
    doList hook to generate the hashes after the distribution is
    created.

commit 9e99010193b583660eb1eb0721a7105ce4fe6c64
Author: Anthony Baker <[email protected]>
Date:   2016-01-12T16:42:06Z

    GEODE-775: Add build support to easily sign release files
    
    Use the gradle signing plugin to sign jar artifacts and distributions.
    This is only done for release versions (-SNAPSHOT).  Exclude KEYS and
    signatures from the distributions.  Requires a user gradle file with
    the following properties:
    
        signing.keyId=
        signing.password=
        signing.secretKeyRingFile=

commit 18842bd4e2a38416d5a0952dfe39df2058547394
Author: Anthony Baker <[email protected]>
Date:   2016-01-12T21:29:02Z

    GEODE-776: Add KEYS file containing code signing keys for releases

commit b202f5dcf10166a445195bfea795f4953eb01e3f
Author: Anthony Baker <[email protected]>
Date:   2016-01-13T01:07:05Z

    GEODE-777: Add sources and javadoc jars
    
    Generate sources and javadoc jars for each subproject.  This is
    important for a maven workflow.

commit 09d39a45bd52a10969b4de35a1cb34467dffc317
Author: Anthony Baker <[email protected]>
Date:   2016-01-13T03:57:13Z

    GEODE-778: Remove grgit plugin to avoid build failures
    
    Applying the grgit plugin in a non-git working tree was causing
    build failures.  Removing the plugin restores the correct
    behavior.

commit a21f9322e01176e3c79dce5f7c16ed7a6c889e4c
Author: Anthony Baker <[email protected]>
Date:   2016-01-14T22:47:59Z

    GEODE-781: Update maven publishing to include signatures
    
    The maven-publish plugin does not grok signature nor sign pom
    files.  These are needed for publishing release versions on Maven
    Central.  Switching over to the nexus plugin simplified signing,
    generation of javadoc / sources jars, and publishing.
    
    To publish to the local maven repository (~/.m2/repository):
      gradle install
    
    To publish to the snapshot / release repositories:
      gradle uploadArtifacts
    
    Signatures will only be created if the following properties are set
    in ~/.gradle.properties:
      signing.keyId
      signing.secretKeyRingFile
      signing.password
    
    To upload the artifacts to Maven, you will need to set the following
    properties in ~/.gradle/gradle.properties:
      nexusUsername
      nexusPassword

commit 1469ca57b8213f1d1affe9ad590256bf9e373e1c
Author: Anthony Baker <[email protected]>
Date:   2016-01-15T19:07:11Z

    GEODE-781: Match repository id to allow Jenkins to upload Maven artifacts

commit 3d04d55b27016bc95fc9435d965c1ecebefe65a9
Author: Anthony Baker <[email protected]>
Date:   2016-01-15T19:36:34Z

    GEODE-781: Another nexus / Jenkins fix for uploading artifacts

commit ea32d2c45cd8f13ed4376029a770b31ba488553f
Author: Anthony Baker <[email protected]>
Date:   2016-01-16T17:14:14Z

    GEODE-781: Remove the maven-publish-auth plugin
    
    Read the settings.xml file directly when build is run by Jenkins.

commit a056631ce24aa4d263d603a3e1f87859b54e766f
Author: Kirk Lund <[email protected]>
Date:   2016-01-18T20:11:10Z

    GEODE-780: Change GFSH to not require Attach API when starting processes

commit ab78b9ef0cd211f676505a613955b83b9644347b
Author: Hitesh Khamesra <[email protected]>
Date:   2016-01-18T23:58:59Z

    Added helpe function for test to know CacheClientProxy state.

commit 0aefb896d223e3bcc0a165a92026e4a546d06d50
Author: Bruce Schuchardt <[email protected]>
Date:   2016-01-19T16:54:20Z

    Converting FilterProfile to use CopyOnWrite collections
    
    There was a lot of overly-complicated code in FilterProfile to implement 
its own
    copy-on-write but we now have CopyOnWriteHashSet and CopyOnWriteHashMap.  
This
    change-set converts FilterProfile to use those classes.
    
    This change-set also includes refactoring of unregisterClientInterest 
performed in a
    group refactoring session last week.  It adds unit tests for 
unregisterClientInterest
    that give 96% code coverage for that algorithm and substantially increased 
coverage
    for registerClientInterest as well.

commit 5eb2f65c0978efeceb699ecf2b60e348f9038828
Author: Bruce Schuchardt <[email protected]>
Date:   2016-01-19T16:56:08Z

    Removing label from continues in AbstractRegionMap
    
    Hitesh discovered that there are no longer inner "while" loops in this
    code and so we no longer need the continuation labels to break out of them.

commit 5d1f93c0e5ac4bdaf78f132a9b30e31c103a3660
Author: Bruce Schuchardt <[email protected]>
Date:   2016-01-19T16:58:14Z

    refactoring RegionVersionHolder.recordVersion()
    
    This is from a group refactoring session during a class taught by Michael 
Feathers.
    The old recordVersion code was difficult to understand and was poorly 
tested.  New
    JUnit tests are now included that give 100% code coverage for this 
algorithm.

commit 4937b597a1e6b474a0eccf3f9bbc0f9682915a7d
Author: Shreedhar Hardikar <[email protected]>
Date:   2016-01-07T22:01:21Z

    GEODE-601: Fix intermittent exception in DiskRegionJUnitTest.
    
    An expected DiskAccessException causes the cache to close
    asynchronously. That leads to a race condition during test tearDown,
    between checking that the cache is closed and it's access. Now wait
    for the cache to close before tearDown.
    Refactors:
     Moved putSuccessful and exceptionOccurred inside Puts
     Remove unnecessary thread creation for Puts in DiskRegionJUnitTest
     Expose _testHandleDiskAccessException through method
    
    This closes #72

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to