-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42729/
-----------------------------------------------------------
Review request for geode, Jens Deppe and Jinmei Liao.
Bugs: GEODE-851
https://issues.apache.org/jira/browse/GEODE-851
Repository: geode
Description
-------
GEODE-851: Cleanup tests in management.internal.security package
* Rename tests so that gradle runs them all
* Flag unimplemented tests with @Ignore
* Rename tests to represent what they are actually testing
* Correct the @Category on each test
* Add ManagementInternalSecurityTestSuite to facilitate running all these tests
together
There are three TODOs in the test code. 2 of these look like potential bugs
that I will file after committing the rename of these tests.
Diffs
-----
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/AuthorizeOperationForDistributedSystemMXBeanIntegrationTest.java
PRE-CREATION
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/AuthorizeOperationForMBeansIntegrationTest.java
PRE-CREATION
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/AuthorizeOperationForRegionCommandsIntegrationTest.java
PRE-CREATION
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthCodeTest.java
c408116
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorizationDetailsIntegrationTest.java
PRE-CREATION
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorizationTest.java
bfd8152
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/ManagementInternalSecurityTestSuite.java
PRE-CREATION
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/OperationCodesForDataCommandsIntegrationTest.java
PRE-CREATION
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/OperationCodesForDistributedSystemMXBeanTest.java
PRE-CREATION
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/ResourceOperationJUnit.java
0d680e6
Diff: https://reviews.apache.org/r/42729/diff/
Testing
-------
com.gemstone.gemfire.management.internal.security tests
Thanks,
Kirk Lund
