----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42768/#review116255 -----------------------------------------------------------
looks good but it would be great if this code has a unit test that exposed the original bug - Darrel Schneider On Jan. 25, 2016, 4:45 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42768/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2016, 4:45 p.m.) > > > Review request for geode, Darrel Schneider and Kirk Lund. > > > Repository: geode > > > Description > ------- > > Don't join the watchDog thread or the proctor thread while holding the > failureSync lock. > > > Diffs > ----- > > gemfire-core/src/main/java/com/gemstone/gemfire/SystemFailure.java > 494f5f7ec3ddb33f2bf2abf202bc1d5c05ea668a > > Diff: https://reviews.apache.org/r/42768/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
