Pulse jar is designed to work as a standalone jar so that it can be deployed separately from the locator. The interaction with the rest of the distributed system is through JMX only.
Isn't this code change in PulseAppListener creating a 'gemfire-core' dependency so every pulse installation would need geode binaries? Even though this may be simpler to implement, reusing the gemfire.properties file would be ideal. Just a suggestion, Nitin ________________________________________ From: Jinmei Liao <[email protected]> on behalf of Jinmei Liao <[email protected]> Sent: Monday, January 25, 2016 8:23 PM To: Jinmei Liao; Jens Deppe Cc: Dan Smith; geode Subject: Re: Review Request 42736: GEODE-854: Put pulseversion.properties in generated-resources > On Jan. 25, 2016, 8:46 p.m., Jinmei Liao wrote: > > Anthony filed a related bug: > > https://issues.apache.org/jira/browse/GEODE-852. I think we should re-use > > the GemfireVersion.properties that is already created in gemfire-core and > > not use this pulseVersion.properties at all. I can go ahead and fix the bug. > > Dan Smith wrote: > Ok. Reusing GemfireVersion.properties seems like a better fix, so if you > want to make those changes, great! If you think it will take a while to make > that fix, I can check this in as a workaround - I made this change because > it's annoying me that the build keeps polluting my source tree. > > Jinmei Liao wrote: > sure, please check this in. Thanks! Oh, it is actually a lot easier than I thought it would be. Just created a pull request for this: https://github.com/apache/incubator-geode/pull/78. Thanks! - Jinmei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42736/#review116161 ----------------------------------------------------------- On Jan. 25, 2016, 8:24 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42736/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2016, 8:24 p.m.) > > > Review request for geode, Jens Deppe and Jinmei Liao. > > > Repository: geode > > > Description > ------- > > Using the same pattern as gemfire-core, put the version properties file > in a generated resources directory, not in source. > > > Diffs > ----- > > gemfire-pulse/build.gradle f2076b5d3d9f2aca45cf32bc0f3861c5cd0dc0ac > > Diff: https://reviews.apache.org/r/42736/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
