All of the subtasks of GEODE-801 are done; I believe this code is ready to be merged.
It's been a week and there have been nothing but positive responses on this thread. I think we should go ahead and merge these changes to develop. Unless I hear otherwise, I plan on merging this code in to develop this Thursday. -Dan On Thu, Jan 21, 2016 at 1:08 PM, Dan Smith <[email protected]> wrote: > If no one objects, I'll start working on cleaning the wan_cq_donation > branch up as described in GEODE-801 tomorrow. This is just getting the code > ready to merge to develop, not the merge itself. > > -Dan > > On Wed, Jan 20, 2016 at 10:27 AM, Dan Smith <[email protected]> wrote: > >> This is great! >> >> These two features are separate gradle modules, so there are no changes >> to existing code. As you are looking at the changes, all of the new code is >> in the gemfire-wan and gemfire-cq modules. One important point is that >> these modules are not adding new public API, they are providing >> implementations for these features using existing extensions points in >> geode - see WANServiceProvider and CQServiceProvider. >> >> There are a few things that need to happen with this code before it gets >> merged to develop, assuming we want to merge this in. I've created >> GEODE-801 to track that work. My suggestion is that we go ahead and get >> started on this work on the wan_cq_donation branch and then if we get >> consensus to merge the changes they will be ready to merge. >> >> If we merge these in to develop this does mean that our next geode >> release will contain these new modules. That might be as soon as 1.0.0.M2. >> But I think it would be better to go ahead and integrate this code sooner >> rather than later so these features are available to users. I'd be in favor >> of merging the changes after the subtasks of GEODE-801 are resolved and >> we've had a week or so to look at the changes and discuss the merge. >> >> -Dan >> >> >> >> On Tue, Jan 19, 2016 at 7:28 PM, Anthony Baker <[email protected]> wrote: >> >>> I am pleased to announce the donation of additional GemFire code to the >>> Geode community. The code being donated adds significant capabilities used >>> by many GemFire customers in production, namely WAN replication and >>> Continuous Query. >>> >>> *WAN replication* provides event delivery and data synchronization for >>> multi-site distributed clusters. Asynchronous, persistent event delivery >>> to remote systems enables patterns such Active/Active, Disaster Recovery, >>> or Follow-the-Sun with support for configurable, eventually consistent data >>> replication. *Continuous Querying* allows clients to subscribe to server >>> events by using SQL-like query filtering. Events that match or modify the >>> query results are queued and delivered to the client using the >>> client/server subscription framework. >>> >>> The Software Grant Agreement for this code has been accepted by the ASF >>> secretary. >>> >>> The donated code currently sits in a separate branch in the Geode >>> repository named wan_cq_donation [1] and is awaiting community feedback. I >>> encourage everyone in the Geode community to review this donation and >>> provide feedback. Once the community has reached a consensus we can >>> determine next steps and how this code might get merged into the develop >>> branch so that all users can access these features. Your suggestions are >>> most welcome! >>> >>> >>> Thanks, >>> Anthony >>> >>> [1] >>> https://git1-us-west.apache.org/repos/asf?p=incubator-geode.git;a=tree;h=refs/heads/wan_cq_donation;hb=refs/heads/wan_cq_donation >>> >>> >> >
