Github user upthewaterspout commented on the pull request:

    https://github.com/apache/incubator-geode/pull/80#issuecomment-175780734
  
    Looks good! One minor point - I think this is missing something that will 
tell gradle what the copyPulsePropFile  task depends on. You could either add a 
dependsOn to the task, or maybe add an inputs.dir to the task:
    
    inputs.dir project(':gemfire-core').sourceSets.main.output
    
    Try running 
    /gradlew  gemfire-pulse:copyPulsePropFile
    or
    /gradlew  gemfire-pulse:war
    
    and you'll see what I mean; it won't generate the original properties file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to