----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43063/#review117411 -----------------------------------------------------------
Ship it! - anilkumar gingade On Feb. 1, 2016, 9:10 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43063/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 9:10 p.m.) > > > Review request for geode, anilkumar gingade, Barry Oglesby, Dan Smith, and > xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Either the test can be changed or we can handle the RegionNotFoundException > and throw the ForceReattemptException. Currently we do the same thing for a > RegionDestroyedException. The RegionNotFoundException is only used by the > query engine and thrown if there is no region that exists for the specified > FROM clause. > > More information about the test: > This test creates a pr across 2 nodes and then asynchronously executes a list > of queries. The main thread sleeps for 5 milliseconds and kicks off another > asynch task that does a region close in one of the randomly chosen nodes but > soon after closing, will recreate the region. > The test expects the thread executing the list of queries to hit a > ForceReattemptException. Based on this, it looks like this test could be > running into a race condition where the query is executing after the region > has been destroyed before query compilation. > Due to the way this test is written, the original test would have probably > always failed intermittently. We can add a RegionNotFoundException to the > check but in the long run we should figure out a way to write a better test > for this scenario. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java > a894efd > > Diff: https://reviews.apache.org/r/43063/diff/ > > > Testing > ------- > > running precheckin > > > Thanks, > > Jason Huynh > >
