----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43162/#review117724 -----------------------------------------------------------
Ship it! Ship It! - Hitesh Khamesra On Feb. 4, 2016, 12:22 a.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43162/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2016, 12:22 a.m.) > > > Review request for geode and Hitesh Khamesra. > > > Repository: geode > > > Description > ------- > > Somehow we missed modifying checkIfAvailable to use the "final" check method > after Jianxia implemented the tcp/ip checks. This modifies checkIfAvailable > to do so. > > Since doFinalCheck uses a thread pool I modified the SuspectRequest to hold > the results of the check so that they are accessible from the > checkIfAvailable method. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java > 172926bf47a9f6633297cdffc5135782f48e16b5 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 0b0cfa02f90a09ff93314f4a6d0d0f3bdbd85e13 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java > 70285c7a0e5f6700c723eb17fb8d68077d68e730 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java > 5becc6a699f3e0d50f3f85f2fcc215a1cbad86dd > > Diff: https://reviews.apache.org/r/43162/diff/ > > > Testing > ------- > > > Thanks, > > Bruce Schuchardt > >
