> On Feb. 8, 2016, 10:01 p.m., Dan Smith wrote: > > I don't think adding the jar to all projects is the correct way to fix > > this. We really shouldn't have *anything* that we're adding to the > > classpath of all projects unless it's really needed in all projects. > > Kirk Lund wrote: > When I execute "./gradlew javadoc" with the changeset in the diff, it > fixes the following javadoc warnings. Without the diff in place, these > warnings are generated by the build: > > > :pivotalgf-assembly:docsC:\dev\gemfire_CLEAN\open\gemfire-core\src\main\java\com\gemstone\gemfire\cache\FailedSynchronizationException.java:33: > warning - Tag @see: reference not found: > javax.transaction.UserTransaction#setRollbackOnly > > C:\dev\gemfire_CLEAN\open\gemfire-core\src\main\java\com\gemstone\gemfire\cache\FailedSynchronizationException.java:33: > warning - Tag @see: reference not found: > javax.transaction.Transaction#registerSynchronization > > C:\dev\gemfire_CLEAN\open\gemfire-core\src\main\java\com\gemstone\gemfire\cache\FailedSynchronizationException.java:33: > warning - Tag @see: reference not found: javax.transaction.Status > > C:\dev\gemfire_CLEAN\open\gemfire-core\src\main\java\com\gemstone\gemfire\cache\SynchronizationCommitConflictException.java:27: > warning - Tag @see: reference not found: > javax.transaction.UserTransaction#commit > > Dan Smith wrote: > You would need to run ./gradlew docs to see these messages. That's the > task running in your comment. > > Your change might fix the issue, I just don't think it's the right way to > fix it. We need to figure out what's broken with that docs task, not add a > jar to the classpath of all of our projects.
"./gradlew javadoc" works too. I'll probably just assign GEODE-945 to you or Anthony then. Sounds like there's a dependency problem in our gradle files. The previous javadoc fixes I committed also added some other dependencies that'll need to be reverted if you don't want them added for javadoc which included transitive dependencies (Anthony reviewed and approved that one so it's already in). - Kirk ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43338/#review118302 ----------------------------------------------------------- On Feb. 8, 2016, 9:46 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43338/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2016, 9:46 p.m.) > > > Review request for geode and Dan Smith. > > > Bugs: GEODE-945 > https://issues.apache.org/jira/browse/GEODE-945 > > > Repository: geode > > > Description > ------- > > Add compile dependency for javax.transaction:javax.transaction-api:1.2 to > satisfy javadoc references to types in javax.transaction package. > > > Diffs > ----- > > gradle/java.gradle 015da2f > > Diff: https://reviews.apache.org/r/43338/diff/ > > > Testing > ------- > > > Thanks, > > Kirk Lund > >
