----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43510/#review119055 -----------------------------------------------------------
Fix it, then Ship it! Ship It! gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/IndexElemArray.java (line 318) <https://reviews.apache.org/r/43510/#comment180341> This error should never actually happen anymore as the len and elements are both changed atomically. I guess it's still safe to return null but we can probably remove the commented out throw line and change the comment to state that this will never happen... - Jason Huynh On Feb. 12, 2016, 1:19 a.m., anilkumar gingade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43510/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2016, 1:19 a.m.) > > > Review request for geode, Barry Oglesby, Jason Huynh, William Markito, and > Dan Smith. > > > Repository: geode > > > Description > ------- > > Fix for GEODE-106 Invalidate operation fails with IndexMaintenanceException > with underlying java.lang.ArrayIndexOutOfBoundsException. > Issue: > IndexElementArrray is used to efficiently (speed/space) manage index data. > There are 2 issues with IndexElemArray, the size and elemendata are not > atomically updated with contains() operation; and while iterating the > elementData content. > Solution: > Lock is added, so that size and elements are modified atomically, and > elementData doesn't change when iteration is started. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/IndexElemArray.java > b94f97500971b37d0ec81a858c4fb4d52e08c3ed > > Diff: https://reviews.apache.org/r/43510/diff/ > > > Testing > ------- > > Unit tests run. Started completed tests. > > > Thanks, > > anilkumar gingade > >
