----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43606/#review119332 -----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java (line 2677) <https://reviews.apache.org/r/43606/#comment180648> Is there no 'else' part to the 'if not null' statement? Otherwise looks good. - Udo Kohlmeyer On Feb. 16, 2016, 5:15 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43606/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 5:15 p.m.) > > > Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > Once in a while a test fails with an NPE in method > Connection.scheduleAckTimeouts() using the variable ackConnectionGroup. This > variable is set to null in setInUse(). > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java > 74660da3d365941b1017e18d427f5d14832c8d93 > > Diff: https://reviews.apache.org/r/43606/diff/ > > > Testing > ------- > > > Thanks, > > Bruce Schuchardt > >
