----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43607/#review119334 -----------------------------------------------------------
Ship it! Ship It! - Udo Kohlmeyer On Feb. 16, 2016, 5:28 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43607/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 5:28 p.m.) > > > Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > If cluster configuration is enabled but a cache.xml is actually being used to > construct the cache then it is possible that after an auto-reconnect a > redundant CacheServer will be created. > > There is an assumption made in writing the auto-reconnect code that if > cluster-configuration is enabled the cache will not be constructed using a > cache.xml file. > > This change-set marks CacheServers that are created by gfsh or so called > "default" servers created by cache.xml processing so that auto-reconnect will > know whether they should be handled specially. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java > c991cc147d975a9bfd44d0c3720f80bc3e35f7ab > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java > 276efec40b088bf7b6f71d418940591a51dd20e2 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java > d75b28dc4271aadde8895e13b0aa5bf97ccd8af5 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerImpl.java > cd4f3e4da1ef479452e527aa92c9d652e3cbaad1 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java > ac198e9c82b5caf11cf8c35d67a745f6da54a515 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheServerHelper.java > b120b577d73d14403fa714ac7f18c292d37f7605 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheCreation.java > f7063bc8536171a22eac06e876ba652a8acaf8f6 > > gemfire-core/src/test/java/com/gemstone/gemfire/cache30/ReconnectedCacheServerDUnitTest.java > 2b97a9afdeacaf9f8b375ee79a7742ba23baa184 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java > 545a0eab1ef189b384fba41b4d97abb3fe60e78a > > Diff: https://reviews.apache.org/r/43607/diff/ > > > Testing > ------- > > > Thanks, > > Bruce Schuchardt > >
