----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43797/ -----------------------------------------------------------
Review request for geode, Barry Oglesby, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer. Repository: geode Description ------- Message size is now restricted to 1GB. If this is exceeded a MessageTooLargeException is thrown. I think the original intent of this ticket was to have messaging handle the carving up of the message into multiple Messages somehow, but I think this is the correct approach. This will ensure that the problem doesn't cause the current connection to be terminated and the operation retried on another server and make sure that the exception gets back to the point of initiation. Barry already has a way to avoid large messages in WAN senders that can be ported to Geode. Diffs ----- gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/OpExecutorImpl.java ca14b76 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/BaseCommand.java dd13f19 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientProxy.java 69ae6d8 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Message.java 4bfd44b gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Part.java f5f6326 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/TXSynchronizationCommand.java 82e8114 gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/MessageJUnitTest.java 3dc5a7d Diff: https://reviews.apache.org/r/43797/diff/ Testing ------- Thanks, Bruce Schuchardt