----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43808/#review120153 -----------------------------------------------------------
gemfire-pulse/build.gradle (line 76) <https://reviews.apache.org/r/43808/#comment181556> Just a question: what does this do? gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/Cluster.java (line 3645) <https://reviews.apache.org/r/43808/#comment181560> this looks like it's trying to convert the string into a json object and if there is any malformat in the string, it will throw an exception which is logged. Should the new code do the same? This entire block looks like test code, so maybe not so important.... gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/DataBrowser.java <https://reviews.apache.org/r/43808/#comment181562> if userQueries is null, would this be a NPE? should we add this block as before? if (userQueries == null) { userQueries = mapper.createObjectNode(); } gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/DataBrowser.java <https://reviews.apache.org/r/43808/#comment181563> same as last comment - Jinmei Liao On Feb. 21, 2016, 6:47 a.m., Jens Deppe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43808/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2016, 6:47 a.m.) > > > Review request for geode, Jinmei Liao and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-907: Converted core functionality to use jackson > GEODE-907: Removed ignored integration tests that are now superceded by unit > tests > GEODE-907: remove com.vmware.gemfire.tools.pulse.internal.json > GEODE-907: Missed some import references > GEODE-907: Fixing rebase merge conflicts > GEODE-907: Switch all fields from floats to doubles > - This is because when Jackson serializes a float (to JSON) it does so > through an implicit cast to a double which alters the precision. > Practically, a number like 23.99F ends up being 23.98999999234D which > messes with unit tests and displaying in the UI. > > GEODE-907: Clean up some issues after rebasing > - CPU usage should be a double and not a string > > > Diffs > ----- > > gemfire-pulse/build.gradle 4e8d98290a19638f21157f59afa7b55d208d3807 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/controllers/PulseController.java > c8737ce0b4871c8c19f0508d73db4cb4affad100 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/Cluster.java > 732a1b0deb52c93af481f1ff7123d7a01ad67fb9 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/DataBrowser.java > dbad2dfb2e96d98058bbe9f1c7f09804726d7a66 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/IClusterUpdater.java > 2b7e1a400c439fe1d05db657a67524ab7476ee59 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/JMXDataUpdater.java > 8e4557a4621394f90b6267d2385ae601533058af > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/PulseConfig.java > 627e37c4dda5972ffc2e2b3f1df9afa5af2c0422 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/json/CDL.java > b6729d445239811a90d6a1035301749390718160 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/json/Cookie.java > 5030dba1f43a9aae4d90aaa01c9cb75e7177c14f > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/json/CookieList.java > 4276b19e09416f8e985d2a3765272ec3cf359594 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/json/HTTP.java > 5d9effe96991fb01e9c8270a35d25d52045764a3 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/json/HTTPTokener.java > 1d8e98fbc85315fbfd5ad8953823945f721ad65f > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/json/JSONArray.java > aa1c272218abd13624194b9c9073eb9a31b6f85c > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/json/JSONException.java > be88930cac378d4f5acfa243b0958fc48a4e5b0d > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/json/JSONML.java > 2ddbffc77b0d5a212c888df89e4976992bf2a54e > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/json/JSONObject.java > d04b1f44bee78e766481bf8aba8814b413ac0516 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/json/JSONString.java > f3c774558ae21d8185c9322e3681a5d6d35e411b > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/json/JSONStringer.java > 41c7065430b2322e73d08c0f8556216911195496 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/json/JSONTokener.java > 2006ee8f8a7c792b69c5e3f4dd64d306cc6ea736 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/json/JSONWriter.java > 7c1590ee0858edf21240e31e66ecf39a9cb86313 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/json/README > 2d7cdcf8a0ccdd29e0b1a3337da4338a51649bce > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/json/XML.java > 2c91414dcb8cd7309551dbe346da3cc09ea6c6e2 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/json/XMLTokener.java > c9f9154aa27a88526fb8a3498483fadb64905326 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/log/PulseLogWriter.java > 3706f12bfa4305a3a0c760282eea9a054be729d0 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/ClusterDetailsService.java > 2efb6aa5514878fb3825dbb2c8f0238172de7972 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/ClusterDiskThroughputService.java > 0c1b56a5bdd57248acd14581d6451dc0c418e0a2 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/ClusterGCPausesService.java > 7c44234d907c882fb4eec4781899a5ebab1a7564 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/ClusterKeyStatisticsService.java > 8ca4c0370963aed0fe1fe68f15629e2a8628660e > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/ClusterMemberService.java > 80e0b2e7ff3f01425354999f3545d3f05f030464 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/ClusterMembersRGraphService.java > f9ca1372b3d2cd6f65dd9455818b347d95817f94 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/ClusterMemoryUsageService.java > 830a44b43b7fe7e20a387f5111fff1a0ae4f9c1c > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/ClusterRegionService.java > bb8950bfb72c969b03271617a59113c0b245929b > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/ClusterRegionsService.java > 5d47d3fe4b5d86de55f67af5f3856d3dc47c66d6 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/ClusterSelectedRegionService.java > f19e78b2c5162ea22b28ae5ea468e5980f2a2116 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/ClusterSelectedRegionsMemberService.java > f4430d5da3b2055f0d0b59094b9a69a1e875c079 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/ClusterWANInfoService.java > 57172bd27cf0c33797d4574d754404c5598ba75d > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/MemberAsynchEventQueuesService.java > 70be387daf3f596d8fcfa8a8c8487fac6932172a > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/MemberClientsService.java > cb4a9e05beebfdb5343ba859f24e8cb05ff93356 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/MemberDetailsService.java > 7e55712729a05fc9463f8261ace973a975368e65 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/MemberDiskThroughputService.java > ce9fb59225a122a6521286441c9251c24a529df4 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/MemberGCPausesService.java > adc01e1606ffbdab66445dfea19f2eb9aa2ffd61 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/MemberGatewayHubService.java > f1efd556c1b6cc62faed1c617ed7a1e4685bb38a > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/MemberHeapUsageService.java > 0073881e05429bb556e7fc51e9acd87bf797b1f1 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/MemberKeyStatisticsService.java > 9dc6126a0c051755c7433d894114c273e150d4a5 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/MemberRegionsService.java > 2c17886057b5626a24edf8e4f22f85536dbc5f1f > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/MembersListService.java > 3a730c5cc601c47c95b46906f9772acb2704d325 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/PulseService.java > e01c9110114da1da01a2735a19fdb398c113f925 > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/PulseVersionService.java > 7d6a7efe57a9797e9c1ab6a61dc20c7e23f7669a > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/QueryStatisticsService.java > a20a2ed6e165d5220635f18caf6330bbd45eec9c > > gemfire-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/SystemAlertsService.java > 4aa556035ed96fad6d8437811d4cb61109ece446 > > gemfire-pulse/src/test/java/com/vmware/gemfire/tools/pulse/controllers/PulseControllerJUnitTest.java > PRE-CREATION > > gemfire-pulse/src/test/java/com/vmware/gemfire/tools/pulse/testbed/PropMockDataUpdater.java > 0cd1d379cdee3ce72383a09be9da56c693f659ea > > gemfire-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/Member.java > 164954397de6431efe7fc2e22658a64603912fec > > gemfire-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/MemberMBean.java > d96fb3b86f4d8b68fc71a91fad5362af84eb0141 > > gemfire-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseBaseTest.java > f239bb6b7bf5cd6eed8b422a1deaa243e8a0e7a3 > > gemfire-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTest.java > b7e5f1f8e6feffac30aad16a9414d1ef64915fca > > gemfire-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/Region.java > a38e5725e5fd982c85e17275e0faf4c7e0b04737 > > gemfire-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/RegionMBean.java > b127b32b2c77b24d77f529b9aa1c39ea52becb9f > > gemfire-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/RegionOnMember.java > 1b7d4c389714296c751848520c8f352483c03df0 > > gemfire-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/RegionOnMemberMBean.java > e67da24ce542e8aac55a16859f57974f713ac50f > > gemfire-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/ServerObject.java > 01eda38f052c3ce6ef389a4593fa8242e34224a6 > > gemfire-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/ServerObjectMBean.java > 19f618e629811aca8a6e91240301be6fac240737 > > gemfire-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/junit/BaseServiceTest.java > 8de628c39172ed03e7100f8a8577c8a2b856ddb7 > > gemfire-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/junit/ClusterSelectedRegionServiceTest.java > 9cbdc945eac89f5e449aac6b825bf5ae7a5d04f5 > > gemfire-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/junit/ClusterSelectedRegionsMemberServiceTest.java > ae59cb6fe12d615a80df5099c8c933e35e6c2d0b > > gemfire-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/junit/MemberGatewayHubServiceTest.java > 7e7416277e434068c6354be1b30d7120138471fd > gradle/dependency-versions.properties > 611ee7a413d70d9c72b5ca0a5384b4dee7c26c60 > > Diff: https://reviews.apache.org/r/43808/diff/ > > > Testing > ------- > > > Thanks, > > Jens Deppe > >
