-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43899/
-----------------------------------------------------------
(Updated Feb. 29, 2016, 9:13 p.m.)
Review request for geode, Anthony Baker, Darrel Schneider, Jens Deppe, Jinmei
Liao, Sai Boorlagadda, and Dan Smith.
Bugs: GEODE-953
https://issues.apache.org/jira/browse/GEODE-953
Repository: geode
Description (updated)
-------
GEODE-953: cleanup geode-junit
* cleanup geode-junit usage of JUnit Rules to ensure JUnit code is always
extended rather than copied
* change CRLF to LF
* remove @author tags
* fix all javadocs
* fix formatting
* add new tests
* remove ExpectedTimeout and ExpectedTimeoutTest (they were dupes of
ExpectedTimeoutRule and ExpectedTimeoutRuleTest)
* use serialization by reflection for serializable subclasses of JUnit rules
that lack sufficient ability to subclass
* repackage rule tests to same package as rules
* repackage serializable rules into serializable sub-package
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/internal/process/PidFileJUnitTest.java
5f81c2b
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/DistributedDisconnectRule.java
125fc06
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/DistributedExternalResource.java
d3b7319
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/DistributedRestoreSystemProperties.java
1711b21
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/RemoteInvoker.java
9e3c5b2
geode-junit/build.gradle 112d112
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/ConditionalIgnore.java
b409cb1
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/IgnoreCondition.java
0caa959
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/IgnoreUntil.java
5910d10
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/Repeat.java 5cfa321
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/Retry.java 65f3cf6
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/ContainerTest.java
8eec738
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/DistributedTest.java
6aa538b
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/DistributedTransactionsTest.java
1892ddd
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/HydraTest.java
4fe535b
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/IntegrationTest.java
1be6e45
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/PerformanceTest.java
ad952be
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/UITest.java
834931a
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/UnitTest.java
d5be9e8
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/WanTest.java
9abf15b
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/ConditionalIgnoreRule.java
80898b5
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/ExpectedTimeout.java
2f53811
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/ExpectedTimeoutRule.java
7b6d345
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/IgnoreUntilRule.java
bf4ec3f
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/RepeatRule.java
7bfe538
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/RetryRule.java
c885aec
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/RuleList.java
PRE-CREATION
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/SerializableExternalResource.java
37d8eb5
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/SerializableRuleChain.java
936345e
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/SerializableTemporaryFolder.java
0e796b3
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/SerializableTestName.java
1fd255f
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/SerializableTestRule.java
354c38a
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/SerializableTestWatcher.java
5bcf686
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/SerializableTimeout.java
3136a1c
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/serializable/FieldSerializationUtils.java
PRE-CREATION
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/serializable/FieldsOfTemporaryFolder.java
PRE-CREATION
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/serializable/FieldsOfTestName.java
PRE-CREATION
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/serializable/FieldsOfTimeout.java
PRE-CREATION
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/serializable/SerializableExternalResource.java
PRE-CREATION
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/serializable/SerializableRuleList.java
PRE-CREATION
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/serializable/SerializableTemporaryFolder.java
PRE-CREATION
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/serializable/SerializableTestName.java
PRE-CREATION
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/serializable/SerializableTestRule.java
PRE-CREATION
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/serializable/SerializableTestWatcher.java
PRE-CREATION
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/serializable/SerializableTimeout.java
PRE-CREATION
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/support/DefaultIgnoreCondition.java
b721c41
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/support/IgnoreConditionEvaluationException.java
0d8a321
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/ExpectedTimeoutJUnitTest.java
24ebdde
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/ExpectedTimeoutRuleTest.java
PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/IgnoreUntilRuleTest.java
PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/RepeatRuleTest.java
PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/RetryRuleGlobalWithErrorTest.java
PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/RetryRuleGlobalWithExceptionTest.java
PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/RetryRuleLocalWithErrorTest.java
PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/RetryRuleLocalWithExceptionTest.java
PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/RuleListTest.java
PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/TestRunner.java
PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/examples/RepeatingTestCasesExampleTest.java
5ee647b
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/examples/RetryRuleExampleTest.java
f6d70a2
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/examples/RuleAndClassRuleTest.java
PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/serializable/SerializableExternalResourceTest.java
PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/serializable/SerializableRuleListTest.java
PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/serializable/SerializableTemporaryFolderTest.java
PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/serializable/SerializableTestNameTest.java
PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/serializable/SerializableTestWatcherTest.java
PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/serializable/SerializableTimeoutTest.java
PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/tests/ExpectedTimeoutRuleTest.java
b67d1eb
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/tests/IgnoreUntilRuleTest.java
a984d1d
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/tests/JUnitRuleTestSuite.java
4c9e315
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/tests/RepeatRuleTest.java
2d37de4
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/tests/RetryRuleGlobalWithErrorTest.java
78bc410
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/tests/RetryRuleGlobalWithExceptionTest.java
114eeb4
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/tests/RetryRuleLocalWithErrorTest.java
af5a853
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/tests/RetryRuleLocalWithExceptionTest.java
1b16a7a
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/tests/RuleAndClassRuleTest.java
9c050e9
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/tests/TestRunner.java
684f452
Diff: https://reviews.apache.org/r/43899/diff/
Testing
-------
precheckin
Thanks,
Kirk Lund