-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44411/
-----------------------------------------------------------

Review request for geode and Sai Boorlagadda.


Bugs: GEODE-982
    https://issues.apache.org/jira/browse/GEODE-982


Repository: geode


Description
-------

collapsed OffHeapCacheDeserializable into StoredObject
Added Slab, SlabFactory, SlabImpl, and AddressableMemoryManager.
collapsed MemoryChunkWithRefCount into StoredObject
methods that access and modify the data now have Data in their name
collapsed AddressableStoredObject into StoredObject changed product code to use 
the StoredObject interface instead of internal class implementations of it
renamed DataAsAddress to TinyStoredObject
renamed ObjectChunk to OffHeapStoredObject
renamed ObjectChunkWithHeapForm to OffHeapStoredObjectWithHeapForm
renamed allocateChunk to allocateOffHeapStoredObject
renamed FakeChunk to SearchMarker
renamed ObjectChunkSlice to OffHeapStoredObjectSlice
renamed SyncChunkStack to OffHeapStoredObjectAddressStack


Diffs
-----

  
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PutAllOp.java
 e81cd0c244af8dc090c835b1259c0ac81f7c0cc1 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PutOp.java 
ef4c9d327817950feacee4122c5741097a881361 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/internal/GetOperationContextImpl.java
 11d9248a9ba8bcf2b7abfd8cfd089cf39aec16c4 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/AbstractIndex.java
 aab99cbb4236292af7dfdb745c4b0e7c34b11ae3 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/DummyQRegion.java
 bde948d0694bc67428335b3a62555d5b20923ce8 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndex.java
 a30a2640e150f4abb23c6316855b82769a16410e 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java
 558ea378db78c70f38ed344f9c5f0ed208d53474 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
 699de2ff2dded0391d7fc88720ccf6523a6f516a 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java 
5b1704055d184e61660e7999018744ab55a92971 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BytesAndBitsForCompactor.java
 cc358f51b1444ed78359f8750362870bd66d626b 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachedDeserializable.java
 04fa51551ad3182b259abfaef97cc512d6c8e42a 
  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 
327279bf21b9afb434ebd6d14fb27b52acd9a644 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskStoreImpl.java 
e4ef21d19986fd7b1eba81eea22e8f49ee8196c0 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java
 19496da8b8e5a8d94fffa81c93e61a958f72522b 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java
 6c5879053dff43896c54350ee47d8a2eb3608d6e 
  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 
b6d8c49c8c3215b6d4e27a688fd5094eaa0be054 
  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/Oplog.java 
3a2d1edea5e378be4049a1bd1afcf37dfbe3c656 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java
 541c45379912781e82ef47b8acdd46c0385dddba 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PreferBytesCachedDeserializable.java
 7ed88b5fedc4625f4faf6fcf247ddd2a4ef1c122 
  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionEntry.java 
e2cfb907c885b7058c190c3ec847c316e4bda481 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java
 a3c9402a28cda899712438e64e788cb71323c54f 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessor.java
 e96d99dc249439f96ebebff1cb23a5d9377ffeeb 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/StoreAllCachedDeserializable.java
 7d94281cc7af0a1cced710d0fc6b957acb2e58f5 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMCachedDeserializable.java
 c5d3c6eb66f66c4c54c7693179e404443c7b5bb5 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/compression/SnappyCompressedCachedDeserializable.java
 05b65dd928b8ec4585d9f9e3dc822b7d43f71ec4 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutMessage.java
 c2ff411c063d69baed7aa58bb2871eb3c6c95203 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Part.java
 80b5c0afa6bfa0df414d14c1aee3045a67dffda5 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Get70.java
 b87903ee14b070980c17feca911cc68050edc677 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Request.java
 6c806c8c51bb1a083ecf80baad95909496e8d63c 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java
 0e506f7ddfde9ccb029933943a0e806bbd81e3ee 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/AbstractStoredObject.java
 6dad277b3cb7bd9f4184c8a38fc6bf9d292011c0 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/AddressableMemoryChunk.java
 7916e1f02e74faada3457eb791b4af5dfb04290e 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/AddressableMemoryChunkFactory.java
 fa2dd782916cf4f9228da5efbd03d6f28df12ce9 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/AddressableMemoryManager.java
 PRE-CREATION 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ByteArrayMemoryChunk.java
 cd0225908d2826067860c90386b098639e71f4fe 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ByteBufferMemoryChunk.java
 1c030f797d62958abcd587cf3ec81814c8a33d13 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/DataAsAddress.java
 96957ac3e3f9df4712ee9f1c849fe0232eefffc9 
  geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/Fragment.java 
d337cfc698c1ea8529496d42a04185dc8b9879c6 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java
 3859d58b076857a4aef0f406ab63b67efe52a110 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryAllocator.java
 0c063ace358e81112200ab824144de774168055e 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryBlock.java 
d8cb80a2c8c2aee8fb45bfdc06c662d79902b566 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryBlockNode.java
 b41d429ef81832c1d0c983fdc87b98b43590270f 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryChunk.java 
012fbe5cdd55c0563d1bd00bcc408867827c95b9 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryChunkWithRefCount.java
 e3ba6abb47fee30f9b3fca978aac51c8b4ee95d9 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ObjectChunk.java 
29e69561f239a0e02948fa0373f0c28ef16cdc3a 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ObjectChunkSlice.java
 3d6bf57538a7514691366c9367fc3897c9c546d0 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ObjectChunkWithHeapForm.java
 5020c7a8a570c3b56e7e12a14e54ed7507e5b2b5 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapCachedDeserializable.java
 bd380e24e78620f48f4deb0193f6995e8fe5135b 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapHelper.java
 4845931693335d3d97a511001412488d476d141e 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java
 b62d97a52b08610fdce0c0ba9825fc4742c9d062 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorImpl.java
 14bde59f9a8c0cd0b0d1e9c97cc368f968b5ea56 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/StoredObject.java
 4d93a07d04bfcc5008b208cf554a9e22f27d0a84 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/SyncChunkStack.java
 99fd96fe633c8f0bf9ae9c9b6c9bbfc968b40182 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/UnsafeMemoryChunk.java
 aebc4595819cac2362335150848ccc8c18eb5b88 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/ByteBufferInputStream.java
 cfc05f29b86b0582af6313804791a24c91af2cd5 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/ImmutableByteBufferInputStream.java
 d632158b35746a9c3e52a77f2fa8a56833eb1ace 
  geode-core/src/main/java/com/gemstone/gemfire/internal/util/BlobHelper.java 
40015a4cdd49a1dabb4a3829c5bdbf54fa509fe5 
  
geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/PdxInputStream.java 
4a5a9dfc8c98c4dfadd6316e5f3bed62d795a4d5 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java
 7a4d09ec6d714d74434bc3cb31094a747a9b4ee2 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ChunkValueWrapperJUnitTest.java
 b69f82ef76ccfcabed020270cdd01c067bd2c055 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/OffHeapTestUtil.java
 cbf3bf6ac99f5a5ef64cc6f87439d64c94b2819d 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/OldValueImporterTestBase.java
 690b55ad5ccf951641c6ae642b3c21a659dbacf8 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/MessageJUnitTest.java
 b7bd47aff58d5a17c155a0c2ed4fb9a77f63384d 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ByteArrayMemoryChunkJUnitTest.java
 e9972a5e53bd9ddf35dd0d5b4c4a717618a4d330 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/DataAsAddressJUnitTest.java
 8a251fdc61d1e0f0f66425ad44241520a50964ad 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/DirectByteBufferMemoryChunkJUnitTest.java
 97b261c105f31ed1e5f181186a6c1261d4903d00 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/FragmentJUnitTest.java
 54eac9eae0672f52a2d94e134aeb6702bf2b1ab5 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/FreeListManagerTest.java
 9bfb2eb3edaf4842ce8f1e2fb699a74451035736 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/FreeListOffHeapRegionJUnitTest.java
 6790f6a5dc2ee47242d643237ec10bebcb045ae9 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/HeapByteBufferMemoryChunkJUnitTest.java
 77cb5ad7b7f1041f5bf48510ccae9cfa8cd50ba4 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/LifecycleListenerJUnitTest.java
 97ae4864ef18f5594f4609f0c25670e6b5aebd10 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/MemoryBlockNodeJUnitTest.java
 3d2dbc71ae908b5b4102324f2d3018be886837da 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/MemoryChunkJUnitTestBase.java
 1b1d300ecf07b698bb038158f78ee810752db42c 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/MemoryChunkTestSuite.java
 29081269c8b4316ed1cbc45672a7a9799a374a92 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ObjectChunkJUnitTest.java
 9271b537c0f622784a27af0ec110f90a4d83f971 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ObjectChunkSliceJUnitTest.java
 fe55910ba204e75d525f2b98badac2de211f2d10 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ObjectChunkWithHeapFormJUnitTest.java
 448684537ad074e9976268ddfd9d06ecb5b79208 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapHelperJUnitTest.java
 b1e3af028557013e5d250856f0b5b5af8505e14f 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionBase.java
 8de040605ab532b47cd92a1be20923d49c050a6b 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java
 5d531090a09aaaa448ec1745c34cdcde90bf649c 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapValidationJUnitTest.java
 630ae22adb0b9bf79f5e958c2aade2062ba59943 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapWriteObjectAsByteArrayJUnitTest.java
 9c83f5b4310c01f9284b8f260f0dc01c22ee8e85 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OldFreeListOffHeapRegionJUnitTest.java
 d8c35b888bbd27dd6a89dacaf4d59675bc210bbb 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorFillPatternIntegrationTest.java
 51f46a104991039261f696cbdb86da1be7a85680 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorFillPatternJUnitTest.java
 7c26f863f1ac35772b42f1928a26842ae7c85770 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorJUnitTest.java
 1f17f9be71e09db20ddd7da693207565fdf8237d 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/StoredObjectTestSuite.java
 feb5de861a2046e581db92f96dc6df73960070a5 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/SyncChunkStackJUnitTest.java
 3ae61595bf10e19c543ced21283f58b508817bb2 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/TinyMemoryBlockJUnitTest.java
 1626a15c9b988aa88648debdedf20093935a1867 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/UnsafeMemoryChunkJUnitTest.java
 d7168a789ca017e96907d3478385ce5c7afb6972 
  
geode-core/src/test/java/com/gemstone/gemfire/management/OffHeapManagementDUnitTest.java
 3d06e11d7966bb69c03c93c802d66821a45bec83 
  
geode-core/src/test/java/com/gemstone/gemfire/pdx/OffHeapByteBufferByteSourceJUnitTest.java
 0f918cb5795e74cbef01d8488f88ea4b6ae710e8 
  
geode-core/src/test/java/com/gemstone/gemfire/pdx/OffHeapByteSourceJUnitTest.java
 64574259af0b9b94e73a6bc442043b087f5a4196 

Diff: https://reviews.apache.org/r/44411/diff/


Testing
-------

precheckin


Thanks,

Darrel Schneider

Reply via email to