----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44458/ -----------------------------------------------------------
(Updated March 7, 2016, 8:14 p.m.) Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer. Changes ------- 1. Changed the test. Make sure checkIfAvailalbe happens before heartbeat response processing. 2. Change the health monitor code, "<=" becomes "<" in checkIfAvailable. Reason, heartbeat response processing could be fast enough, so that startTime == ts. Another option is, if we don't want to change the product code, enforce a slight delay (e.g. Thread.sleep) before processing the hearbeat response. This can be done by adding a sleep in doTCPCheckMember in the test. Repository: geode Description ------- It is still possible that during checkIfAvailable the time stamp of the heartbeat response is the same as the checkIfAvailable startTime. That's why the unit test fails. Diffs (updated) ----- geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java 536e26e geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java a96b546 Diff: https://reviews.apache.org/r/44458/diff/ Testing ------- Thanks, Jianxia Chen
