> On March 9, 2016, 10:10 p.m., anilkumar gingade wrote: > > geode-core/src/test/java/com/gemstone/gemfire/cache/query/TestUtils.java, > > line 18 > > <https://reviews.apache.org/r/44593/diff/1/?file=1293704#file1293704line18> > > > > We have QueryTestUtils.java; added to capture all the common code; and > > queries used (this has helped a lot while refering for example > > queries)...Can we move this there...that way we will have one common query > > test util....
Sure, I'll look into using QueryTestUtils. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44593/#review122820 ----------------------------------------------------------- On March 9, 2016, 9:51 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44593/ > ----------------------------------------------------------- > > (Updated March 9, 2016, 9:51 p.m.) > > > Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan > Smith, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > InitialImagePut code executes a BEFORE_UPDATE_OP on indexes for updates > > This is required for updates to indexes to be able to extract the appropriate > key to update and also allows the index to figure out that an update is > occuring vs an add. > Adding a TestUtils class for query tests. Hopefully converging/converting > existing utilities from existing tests into this class. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java > 9058984 > geode-core/src/test/java/com/gemstone/gemfire/cache/query/TestUtils.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/PartitionedRegionCompactRangeIndexDUnitTest.java > PRE-CREATION > > geode-core/src/test/resources/com/gemstone/gemfire/cache/query/dunit/PersistentPartitionWithIndex.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/44593/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
