----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44599/#review122837 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java (line 936) <https://reviews.apache.org/r/44599/#comment184940> You need to add some comments explaining the difference between coordinators and possibleCoordinators. Maybe coordinators should be renamed coordinatorsWithView. geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java (line 975) <https://reviews.apache.org/r/44599/#comment184937> missing braces geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java (line 993) <https://reviews.apache.org/r/44599/#comment184939> missing braces - Bruce Schuchardt On March 9, 2016, 11:25 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44599/ > ----------------------------------------------------------- > > (Updated March 9, 2016, 11:25 p.m.) > > > Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > Now in findCoordinator call we give preference to member which has already > created view. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 3d8b2e5 > > Diff: https://reviews.apache.org/r/44599/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
