----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44869/#review123799 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/control/HeapMemoryMonitor.java (line 466) <https://reviews.apache.org/r/44869/#comment186061> we have this same basic code in two other places but they test for != -1 instead of > 0. This seems like a better test since testBytesUsedForThresholdSet is intialized to -1. Also I think you should change the two places in this class that do this: if (testBytesUsedForThresholdSet != -1) { updateStateAndSendEvent(testBytesUsedForThresholdSet); } else { updateStateAndSendEvent(getBytesUsed()); } to now just call updateStateAndSendEvent() since you are changing it to have this logic. Those two places are: setCriticalThreshold and setEvictionThreshold - Darrel Schneider On March 15, 2016, 3:25 p.m., Sai Boorlagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44869/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 3:25 p.m.) > > > Review request for geode, Darrel Schneider, Eric Shu, and Swapnil Bawaskar. > > > Bugs: GEODE-1096 > https://issues.apache.org/jira/browse/GEODE-1096 > > > Repository: geode > > > Description > ------- > > Fixed updateStateAndSendEvent to consider testBytesUsedForThresholdSet > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/control/HeapMemoryMonitor.java > 27a6dffe8d41bbb3dbe44700e4980b513bb07121 > > Diff: https://reviews.apache.org/r/44869/diff/ > > > Testing > ------- > > precheckin and regression tests > > > Thanks, > > Sai Boorlagadda > >
