----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44968/#review124074 -----------------------------------------------------------
Fix it, then Ship it! gradle/java.gradle <https://reviews.apache.org/r/44968/#comment186419> Is there ever a time where a sub-project is not dependent on geode-core and would use the findbugs-annotations? No issue moving it now since we don't have that configuration now, however, might need to move it back later. - Mark Bretl On March 17, 2016, 10:52 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44968/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 10:52 a.m.) > > > Review request for geode, Jason Huynh and Jens Deppe. > > > Repository: geode > > > Description > ------- > > A few more things to clean up our dependencies a bit. > > We really shouldn't have any dependencies that are included for all projects. > Moving the findbugs annotations in to geode core. Unfortunately, I still had > to leave it as compile scope just so that downstream consumers won't get > warnings when they compile against the geode jar. > > Removing a few forced versions that don't seem to be necessary. > > > Diffs > ----- > > geode-assembly/build.gradle 5930f13c5307e0cd70396b019263176a377d415a > geode-assembly/src/test/resources/expected_jars.txt PRE-CREATION > geode-core/build.gradle 041dc07c860c008f117d37969ee688375c2a348d > gradle/dependency-resolution.gradle PRE-CREATION > gradle/java.gradle PRE-CREATION > > Diff: https://reviews.apache.org/r/44968/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
