-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44977/
-----------------------------------------------------------
Review request for geode, Jens Deppe, Jinmei Liao, and William Markito.
Bugs: GEODE-949
https://issues.apache.org/jira/browse/GEODE-949
Repository: geode
Description
-------
GEODE-949: refactor and repackage security test code
Uploading the full diffs for Geode here.
* test security classes under security package are now in
com.gemstone.gemfire.security.generator
* test security resources under lib package are now in
com.gemstone.gemfire.security.generator
* test security classes under templates.security package are now in
com.gemstone.gemfire.security.templates
* fixed places where security code was eating exceptions
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/auth/GMSAuthenticator.java
ba35e46
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/CacheServerSSLConnectionDUnitTest.java
5fa4fc4
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DurableClientBug39997DUnitTest.java
fb8fb3e
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationDUnitTest.java
8446eae
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationDUnitTest.java
1d0b481
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationTestBase.java
55edaa1
geode-core/src/test/java/com/gemstone/gemfire/security/ClientMultiUserAuthzDUnitTest.java
dc03990
geode-core/src/test/java/com/gemstone/gemfire/security/DeltaClientAuthorizationDUnitTest.java
5c184d1
geode-core/src/test/java/com/gemstone/gemfire/security/DeltaClientPostAuthorizationDUnitTest.java
ec1c692
geode-core/src/test/java/com/gemstone/gemfire/security/P2PAuthenticationDUnitTest.java
d47b1c4
geode-core/src/test/java/com/gemstone/gemfire/security/generator/AuthzCredentialGenerator.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/generator/CredentialGenerator.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/generator/DummyAuthzCredentialGenerator.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/generator/DummyCredentialGenerator.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/generator/LdapUserCredentialGenerator.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/generator/PKCSCredentialGenerator.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/generator/SSLCredentialGenerator.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/generator/UserPasswordWithExtraPropsAuthInit.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/generator/XmlAuthzCredentialGenerator.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/templates/DummyAuthenticator.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/templates/DummyAuthorization.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/templates/FunctionSecurityPrmsHolder.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/templates/LdapUserAuthenticator.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSAuthInit.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSAuthenticator.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSPrincipal.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSPrincipalTest.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/templates/UserPasswordAuthInit.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/templates/UsernamePrincipal.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/templates/UsernamePrincipalTest.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/templates/XmlAuthorization.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/security/templates/XmlErrorHandler.java
PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NamedCallable.java
66a3f38
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NamedRunnable.java
8a7fe28
geode-core/src/test/java/security/AuthzCredentialGenerator.java fdd10b0
geode-core/src/test/java/security/CredentialGenerator.java 475cefa
geode-core/src/test/java/security/DummyAuthzCredentialGenerator.java 8496be3
geode-core/src/test/java/security/DummyCredentialGenerator.java 5419587
geode-core/src/test/java/security/LdapUserCredentialGenerator.java 2b95616
geode-core/src/test/java/security/PKCSCredentialGenerator.java 5b6d5fa
geode-core/src/test/java/security/SSLCredentialGenerator.java e547630
geode-core/src/test/java/security/UserPasswordWithExtraPropsAuthInit.java
cc585cd
geode-core/src/test/java/security/XmlAuthzCredentialGenerator.java 118e86f
geode-core/src/test/java/templates/security/DummyAuthenticator.java 5070836
geode-core/src/test/java/templates/security/DummyAuthorization.java 4c2bfec
geode-core/src/test/java/templates/security/FunctionSecurityPrmsHolder.java
5771fd4
geode-core/src/test/java/templates/security/LdapUserAuthenticator.java
49059c3
geode-core/src/test/java/templates/security/PKCSAuthInit.java f4004f3
geode-core/src/test/java/templates/security/PKCSAuthenticator.java 7af7312
geode-core/src/test/java/templates/security/PKCSPrincipal.java bc3049f
geode-core/src/test/java/templates/security/PKCSPrincipalTest.java fc8454c
geode-core/src/test/java/templates/security/UserPasswordAuthInit.java 1c48773
geode-core/src/test/java/templates/security/UsernamePrincipal.java 781dd5a
geode-core/src/test/java/templates/security/UsernamePrincipalTest.java
023c214
geode-core/src/test/java/templates/security/XmlAuthorization.java 29d94de
geode-core/src/test/java/templates/security/XmlErrorHandler.java 1326548
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/authz-dummy.xml
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/authz-ldap.xml
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/authz-multiUser-dummy.xml
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/authz-multiUser-ldap.xml
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/gemfire1.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/gemfire10.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/gemfire11.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/gemfire2.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/gemfire3.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/gemfire4.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/gemfire5.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/gemfire6.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/gemfire7.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/gemfire8.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/gemfire9.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/ibm/gemfire1.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/ibm/gemfire10.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/ibm/gemfire11.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/ibm/gemfire2.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/ibm/gemfire3.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/ibm/gemfire4.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/ibm/gemfire5.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/ibm/gemfire6.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/ibm/gemfire7.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/ibm/gemfire8.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/ibm/gemfire9.keystore
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/ibm/publickeyfile
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/generator/keys/publickeyfile
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/templates/authz5_5.dtd
PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/security/templates/authz6_0.dtd
PRE-CREATION
geode-core/src/test/resources/lib/authz-dummy.xml 7f73808
geode-core/src/test/resources/lib/authz-ldap.xml e63c23b
geode-core/src/test/resources/lib/authz-multiUser-dummy.xml 0f3bbab
geode-core/src/test/resources/lib/authz-multiUser-ldap.xml a8e5392
geode-core/src/test/resources/lib/keys/gemfire1.keystore 15270bb
geode-core/src/test/resources/lib/keys/gemfire10.keystore bb6f827
geode-core/src/test/resources/lib/keys/gemfire11.keystore 6839c74
geode-core/src/test/resources/lib/keys/gemfire2.keystore fcb7ab8
geode-core/src/test/resources/lib/keys/gemfire3.keystore 19afc4b
geode-core/src/test/resources/lib/keys/gemfire4.keystore c65916a
geode-core/src/test/resources/lib/keys/gemfire5.keystore d738cca
geode-core/src/test/resources/lib/keys/gemfire6.keystore 1fea2d3
geode-core/src/test/resources/lib/keys/gemfire7.keystore 7a3187c
geode-core/src/test/resources/lib/keys/gemfire8.keystore a3bb886
geode-core/src/test/resources/lib/keys/gemfire9.keystore 674b4e6
geode-core/src/test/resources/lib/keys/ibm/gemfire1.keystore 4f9120c
geode-core/src/test/resources/lib/keys/ibm/gemfire10.keystore 0bd97d7
geode-core/src/test/resources/lib/keys/ibm/gemfire11.keystore 62ae3c7
geode-core/src/test/resources/lib/keys/ibm/gemfire2.keystore c65bc81
geode-core/src/test/resources/lib/keys/ibm/gemfire3.keystore b0796e0
geode-core/src/test/resources/lib/keys/ibm/gemfire4.keystore 9c94018
geode-core/src/test/resources/lib/keys/ibm/gemfire5.keystore 33f6937
geode-core/src/test/resources/lib/keys/ibm/gemfire6.keystore 568f674
geode-core/src/test/resources/lib/keys/ibm/gemfire7.keystore 80e2d80
geode-core/src/test/resources/lib/keys/ibm/gemfire8.keystore a15def5
geode-core/src/test/resources/lib/keys/ibm/gemfire9.keystore 72087f3
geode-core/src/test/resources/lib/keys/ibm/publickeyfile 1b13872
geode-core/src/test/resources/lib/keys/publickeyfile 9c2daa3
geode-core/src/test/resources/templates/security/authz5_5.dtd 81a8150
geode-core/src/test/resources/templates/security/authz6_0.dtd 06cceff
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java
344c977
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientCQPostAuthorizationDUnitTest.java
0cb125f
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java
62bff2b
geode-cq/src/test/java/com/gemstone/gemfire/security/MultiuserAPIDUnitTest.java
7161830
geode-cq/src/test/java/com/gemstone/gemfire/security/MultiuserDurableCQAuthzDUnitTest.java
9f9d4c0
Diff: https://reviews.apache.org/r/44977/diff/
Testing
-------
precheckin
hydra security battery tests
Thanks,
Kirk Lund
