> On March 21, 2016, 11:49 p.m., Swapnil Bawaskar wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/redis/RegionProvider.java, > > line 402 > > <https://reviews.apache.org/r/45077/diff/1/?file=1307404#file1307404line402> > > > > The reason we decided to go the gfsh route for creating regions was > > that we wanted to work with cluster configuration. With the existing code, > > if you did an export-cluster-configuration all the regions created by Redis > > adaptor will show up. With the new code, they will not. > > > > To me, the fact that programatically created regions do not show up in > > exported cluster configuration is broken.
I have added https://issues.apache.org/jira/browse/GEODE-1119 for fixing the programmatically creating regions issue. - Swapnil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45077/#review124686 ----------------------------------------------------------- On March 19, 2016, 8:23 p.m., William Markito wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45077/ > ----------------------------------------------------------- > > (Updated March 19, 2016, 8:23 p.m.) > > > Review request for geode and Swapnil Bawaskar. > > > Bugs: GEODE-1113 > https://issues.apache.org/jira/browse/GEODE-1113 > > > Repository: geode > > > Description > ------- > > GEODE-1113 - Redis Adapter region creation performance problems > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/redis/ExecutionHandlerContext.java > 0f4f341 > > geode-core/src/main/java/com/gemstone/gemfire/internal/redis/RegionProvider.java > dcd83cb > > Diff: https://reviews.apache.org/r/45077/diff/ > > > Testing > ------- > > Precheckin. > redis-benchmark. > Spring cloud Dataflow tests. > > > Thanks, > > William Markito > >
